Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names in comment #23008

Merged
merged 1 commit into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crypto/types/multisig/multisignature.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func NewMultisig(n int) *signing.MultiSignatureData {
}
}

// GetIndex returns the index of pk in keys. Returns -1 if not found
// getIndex returns the index of pk in keys. Returns -1 if not found
func getIndex(pk types.PubKey, keys []types.PubKey) int {
for i := 0; i < len(keys); i++ {
if pk.Equals(keys[i]) {
Expand Down
4 changes: 2 additions & 2 deletions math/int.go
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ func (i *Int) UnmarshalJSON(bz []byte) error {
return unmarshalJSON(i.i, bz)
}

// MarshalJSON for custom encoding scheme
// marshalJSON for custom encoding scheme
// Must be encoded as a string for JSON precision
func marshalJSON(i encoding.TextMarshaler) ([]byte, error) {
text, err := i.MarshalText()
Expand All @@ -446,7 +446,7 @@ func marshalJSON(i encoding.TextMarshaler) ([]byte, error) {
return json.Marshal(string(text))
}

// UnmarshalJSON for custom decoding scheme
// unmarshalJSON for custom decoding scheme
// Must be encoded as a string for JSON precision
func unmarshalJSON(i *big.Int, bz []byte) error {
var text string
Expand Down
2 changes: 1 addition & 1 deletion runtime/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ type coreKVStore struct {
kvStore storetypes.KVStore
}

// NewKVStore returns a wrapper of Core/Store kvstore interface
// newKVStore returns a wrapper of Core/Store kvstore interface
func newKVStore(store storetypes.KVStore) store.KVStore {
return coreKVStore{kvStore: store}
}
Expand Down
2 changes: 1 addition & 1 deletion simapp/v2/simdv2/cmd/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"github.com/cosmos/cosmos-sdk/crypto/keyring"
)

// initAppConfig helps to override default client config template and configs.
// initClientConfig helps to override default client config template and configs.
// return "", nil if no custom configuration is required for the application.
func initClientConfig() (string, interface{}) {
type GasConfig struct {
Expand Down
2 changes: 1 addition & 1 deletion x/auth/migrations/legacytx/stdtx.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func (tx StdTx) GetSignaturesV2() ([]signing.SignatureV2, error) {
return res, nil
}

// GetPubkeys returns the pubkeys of signers if the pubkey is included in the signature
// GetPubKeys returns the pubkeys of signers if the pubkey is included in the signature
// If pubkey is not included in the signature, then nil is in the slice instead
func (tx StdTx) GetPubKeys() ([]cryptotypes.PubKey, error) {
pks := make([]cryptotypes.PubKey, len(tx.Signatures))
Expand Down
Loading