R4R: New broadcast command #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2240 +/- ##
========================================
Coverage 63.74% 63.74%
========================================
Files 140 140
Lines 8645 8645
========================================
Hits 5511 5511
Misses 2755 2755
Partials 379 379 |
alessio
force-pushed
the
alessio/1954-submit-signed-tx
branch
8 times, most recently
from
2f85aaf to
1cf2d5f
Compare
fedekunze
previously requested changes
Sep 7, 2018
|
Lets vote:
|
alessio
force-pushed
the
alessio/1954-submit-signed-tx
branch
2 times, most recently
from
f4c46a7 to
f0c27ed
Compare
alessio
force-pushed
the
alessio/1954-submit-signed-tx
branch
from
28afbda to
8ee7a52
Compare
|
@alessio FYI, you don't need to squash while writing the PR, that can be done by the reviewer at the end. |
Implement broadcast command/REST endpoint to submit transactions generated offline with --generated-only and the sign command. Closes: #1954
alessio
force-pushed
the
alessio/1954-submit-signed-tx
branch
from
8708c44 to
4c8cd38
Compare
cwgoes
approved these changes
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
broadcastcommand/REST endpoint to submit transactions generated offline with--generated-onlyand thesigncommand.Closes: #1954
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: