ci: Use large box for 052 branch sims on CI #21067
Conversation
WalkthroughWalkthroughThe recent changes to the GitHub Actions workflow streamline the CI/CD process by removing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/sims-052.yml (6 hunks)
Additional comments not posted (12)
.github/workflows/sims-052.yml (12)
63-64: Verify the runner environment change for thetest-sim-deterministicjob.The
runs-on: large-sdk-runnerchange should be verified to ensure it meets the requirements for thetest-sim-deterministicjob.
47-48: Verify the runner environment change for thetest-sim-after-importjob.The
runs-on: large-sdk-runnerchange should be verified to ensure it meets the requirements for thetest-sim-after-importjob.
97-97: Verify the runner environment change for thesims-notify-successjob.The
runs-on: large-sdk-runnerchange should be verified to ensure it meets the requirements for thesims-notify-successjob.Verification successful
The runner environment change to
large-sdk-runnerfor thesims-notify-successjob is verified and appears to be correct.The
large-sdk-runneris used consistently across multiple workflow files, indicating it is a standard and appropriate runner environment for this job.
.github/workflows/sims-052.yml.github/workflows/sims.ymlScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the runner environment for the `sims-notify-success` job. # Test: Check the documentation for `large-sdk-runner`. Expect: It meets the requirements for the `sims-notify-success` job. rg --type md 'large-sdk-runner'Length of output: 31
Script:
#!/bin/bash # Description: Verify the runner environment for the `sims-notify-success` job. # Test: Search for references to `large-sdk-runner` in the `.github/workflows` directory. rg 'large-sdk-runner' .github/workflows/*.ymlLength of output: 1893
18-18: Verify the runner environment change for thebuildjob.The
runs-on: large-sdk-runnerchange should be verified to ensure it meets the requirements for thebuildjob.
48-48: Verify the dependencies change for thetest-sim-after-importjob.The
needs: [build]change should be verified to ensure it meets the requirements for thetest-sim-after-importjob.Verification successful
Verify the dependencies change for the
test-sim-after-importjob.The
test-sim-import-exportjob is correctly set to depend on thebuildjob as indicated by theneeds: [build]configuration. This ensures that thebuildjob runs before thetest-sim-import-exportjob, meeting the requirements.
.github/workflows/sims-052.yml:
jobssection definesbuildandtest-sim-import-exportjobs.test-sim-import-exportjob includesneeds: [build].Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the dependencies for the `test-sim-after-import` job. # Test: Check the documentation for the `build` job. Expect: It meets the requirements for the `test-sim-after-import` job. rg --type yaml 'build' | rg 'test-sim-after-import'Length of output: 49
Script:
#!/bin/bash # Description: Verify the dependencies for the `test-sim-after-import` job. # Search for the definition of the `build` job in YAML files rg --type yaml 'build:' # Search for the definition of the `test-sim-after-import` job in YAML files rg --type yaml 'test-sim-after-import:'Length of output: 63
Script:
#!/bin/bash # Description: Verify the dependencies for the `test-sim-after-import` job. # Search for all job definitions in YAML files rg --type yaml 'jobs:'Length of output: 22
Script:
#!/bin/bash # Description: Verify the dependencies for the `test-sim-after-import` job. # Search for the `jobs` keyword in the .github/workflows/sims-052.yml file rg 'jobs:' .github/workflows/sims-052.yml -A 20Length of output: 567
16-18: Verify the added permissions for thebuildjob.The
contents: readpermission is necessary foractions/checkoutto fetch code. Ensure this permission is sufficient and doesn't require additional permissions.
124-124: Verify the runner environment change for thesims-notify-failurejob.The
runs-on: large-sdk-runnerchange should be verified to ensure it meets the requirements for thesims-notify-failurejob.
79-80: Verify the runner environment change for thetest-sim-multi-seed-shortjob.The
runs-on: large-sdk-runnerchange should be verified to ensure it meets the requirements for thetest-sim-multi-seed-shortjob.
31-32: Verify the runner environment change for thetest-sim-import-exportjob.The
runs-on: large-sdk-runnerchange should be verified to ensure it meets the requirements for thetest-sim-import-exportjob.
64-64: Verify the dependencies change for thetest-sim-deterministicjob.The
needs: [build]change should be verified to ensure it meets the requirements for thetest-sim-deterministicjob.Verification successful
The dependency setup for the
test-sim-deterministicjob is correct.The
needs: [build]directive ensures that thetest-sim-deterministicjob runs only after thebuildjob completes, which is appropriate given the steps involved.
.github/workflows/sims-052.yml:
test-sim-deterministicjob depends on thebuildjob, ensuring the latest build is used for testing.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the dependencies for the `test-sim-deterministic` job. # Test: Check the documentation for the `build` job. Expect: It meets the requirements for the `test-sim-deterministic` job. rg --type yaml 'build' | rg 'test-sim-deterministic'Length of output: 50
Script:
#!/bin/bash # Extract the definition of the `test-sim-deterministic` job rg -A 20 'test-sim-deterministic:' .github/workflows/sims-052.yml # Extract the definition of the `build` job rg -A 20 'build:' .github/workflows/sims-052.ymlLength of output: 1185
32-32: Verify the dependencies change for thetest-sim-import-exportjob.The
needs: [build]change should be verified to ensure it meets the requirements for thetest-sim-import-exportjob.
80-80: Verify the dependencies change for thetest-sim-multi-seed-shortjob.The
needs: [build]change should be verified to ensure it meets the requirements for thetest-sim-multi-seed-shortjob.
* main: feat(log): remove core dependency and update core interface to be dependency free (#21045) chore: fix some comments (#21085) feat: simulate nested messages (#20291) chore(network): remove `DefaultConfigWithAppConfigWithQueryGasLimit` (#21055) fix(runtime): remove `appv1alpha1.Config` from runtime (#21042) feat(simapp/v2): Add store server to testnet init cmd (#21076) chore(indexer/postgres): update to changes on main (#21077) feat(schema/appdata): async listener mux'ing (#20879) ci: Use large box for 052 branch sims on CI (#21067) chore(all): replace all `fmt.Errorf` without paramters with `errors.New` (#21068)
Description
Updates CI config only:
large-sdk-runnertest-sim-deterministicto CI runrunsimsetupAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Improvements
install-runsimjob and adjusting job dependencies, improving execution speed and reliability.Bug Fixes