refactor(x/group)!: remove MustAccAddressFromBech32 #20082
Conversation
WalkthroughThe update primarily involves integrating an Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| * [#20082](https://github.com/cosmos/cosmos-sdk/pull/20082) Removes the use of `MustAccAddressFromBech32`: | ||
| * `PrimaryKeyFields` function from interface `PrimaryKeyed` now takes an address codec as argument. | ||
| * `PrimaryKey`, `NewAutoUInt64Table` and `NewPrimaryKeyTable` now take an address codec as argument. |
There was a problem hiding this comment.
Ensure consistent indentation for list items in the changelog to improve readability.
- * `PrimaryKeyFields` function from interface `PrimaryKeyed` now takes an address codec as argument.
- * `PrimaryKey`, `NewAutoUInt64Table` and `NewPrimaryKeyTable` now take an address codec as argument.
+ * `PrimaryKeyFields` function from interface `PrimaryKeyed` now takes an address codec as argument.
+ * `PrimaryKey`, `NewAutoUInt64Table` and `NewPrimaryKeyTable` now take an address codec as argument.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * [#20082](https://github.com/cosmos/cosmos-sdk/pull/20082) Removes the use of `MustAccAddressFromBech32`: | |
| * `PrimaryKeyFields` function from interface `PrimaryKeyed` now takes an address codec as argument. | |
| * `PrimaryKey`, `NewAutoUInt64Table` and `NewPrimaryKeyTable` now take an address codec as argument. | |
| * [#20082](https://github.com/cosmos/cosmos-sdk/pull/20082) Removes the use of `MustAccAddressFromBech32`: | |
| * `PrimaryKeyFields` function from interface `PrimaryKeyed` now takes an address codec as argument. | |
| * `PrimaryKey`, `NewAutoUInt64Table` and `NewPrimaryKeyTable` now take an address codec as argument. |
x/group/keeper/grpc_query.go
Outdated
| @@ -311,7 +311,7 @@ func (k Keeper) GroupsByMember(ctx context.Context, request *group.QueryGroupsBy | |||
| // getVote gets the vote info for the given proposal id and voter address. | |||
| func (k Keeper) getVote(ctx context.Context, proposalID uint64, voter string) (group.Vote, error) { | |||
| var v group.Vote | |||
| return v, k.voteTable.GetOne(k.KVStoreService.OpenKVStore(ctx), orm.PrimaryKey(&group.Vote{ProposalId: proposalID, Voter: voter}), &v) | |||
| return v, k.voteTable.GetOne(k.KVStoreService.OpenKVStore(ctx), orm.PrimaryKey(&group.Vote{ProposalId: proposalID, Voter: voter}, k.accKeeper.AddressCodec()), &v) | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Several files in the codebase still use the getVote function, but no explicit unit tests were found that cover the integration of the new address.Codec. It is recommended to add or verify existing tests to ensure the new integration works as expected.
./x/group/keeper/grpc_query.go: Usage ofgetVoteand related functions.
Analysis chain
Integration of address.Codec in getVote looks correct.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that the new address codec integration is covered by unit tests.
rg --type go "Test_getVote" ./x/group/keeper/
Length of output: 45
Script:
#!/bin/bash
# Broaden the search for unit tests related to the `getVote` function to ensure coverage of the new address codec integration.
rg --type go "getVote" ./x/group/keeper/
Length of output: 1114
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Description
ref:
#13140
#7448
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
API Changes
New Features
Refactor
Bug Fixes