v2 genesis #20076

kocubinski · 2024-04-17T16:56:03Z

Description

Progresses work on Genesis to a point where stf.deliverTx fails during TxValidation at this site: https://github.com/cosmos/cosmos-sdk/blob/kocu/genesis-v2/x/auth/module.go#L148-L151 due to a cast to sdk.Context.

Hoists GenTxs up to AppManager[T].InitGenesis so that genesis txs are included in the genesis block.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

- genesis subcommand needs implementation

coderabbitai · 2024-04-17T16:56:20Z

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kocubinski · 2024-04-17T17:31:31Z

core/context/context.go

+type ContextKey string
+
+// TODO: remove
+const CometInfoKey ContextKey = "comet-info"


For usage see: https://github.com/cosmos/cosmos-sdk/blob/kocu/genesis-v2/x/distribution/keeper/abci.go#L27
I think this can be resolved with #19602 which adds a message to retrieve CometInfo from the RouterService, or optionally including a keeper.

core/transaction/transaction.go

server/v2/cometbft/abci.go

kocubinski · 2024-04-17T17:38:13Z

runtime/v2/manager.go

@@ -26,6 +28,7 @@ import (

 	"github.com/cosmos/cosmos-sdk/codec"
 	sdkmodule "github.com/cosmos/cosmos-sdk/types/module"
+	"github.com/cosmos/cosmos-sdk/x/genutil/types"


To remove this dependency a genesis themed extension interface in x/genutil could be used to return []json.RawMessage for server v2.

server/v2/cometbft/utils.go

…cu/genesis-v2

x/consensus/keeper/keeper.go

+					Power:   evi.Validator.Power,
+				},
+				Height:           evi.Height,
+				Time:             &evi.Time,


server/v2/cometbft/utils.go

 			Height:           e.Height,
-			Time:             &timestamppb.Timestamp{Seconds: int64(e.Time.Second())}, // safe?
+			Time:             &e.Time,


runtime/v2/manager.go

x/distribution/keeper/abci.go

+			previousTotalPower += vote.Validator.Power
+		}
+		voteInfos := cometInfo.LastCommit.Votes
+		if err := k.AllocateTokens(ctx, previousTotalPower, voteInfos); err != nil {


x/distribution/module.go

server/v2/appmanager/appmanager.go

julienrbrt · 2024-04-26T13:04:40Z

runtime/v2/manager.go

+		}
+
+		// we might get an adapted module, a native core API module or a legacy module
+		if module, ok := mod.(appmodule.HasGenesisAuto); ok {


we shouldn't support appmodule.HasGenesisAuto here, imho only appmodulev2 logic.

runtime/v2/manager.go

+				return fmt.Errorf("failed to unmarshal %s genesis state: %w", moduleName, err)
+			}
+			for _, jsonTx := range genesisState.GenTxs {
+				txHandler(jsonTx)


kocubinski and others added 7 commits April 11, 2024 11:09

poc query validator set from Consensus.InitChain

50a2333

genesis hacking, exporing end block for val updates

481d327

add a way to run in an stf context without blocks

f971ee6

form dependency on x/consensus in x/upgrade for params

f547b91

patching staking and dist for v2 genesis

326345d

progress to empty valset

db09b12

- genesis subcommand needs implementation

progress init genesis to work with genTx as regular txs

1f98e32

kocubinski changed the title ~~Kocu/genesis v2~~ v2 genesis Apr 17, 2024

github-actions bot added C:x/staking C:x/slashing C:x/distribution distribution module related C:Store C:x/evidence C:x/upgrade C:x/consensus labels Apr 17, 2024

kocubinski mentioned this pull request Apr 17, 2024

feat(runtime/v2): Export Genesis #20009

Merged

12 tasks

revert importState signature change

b4452e1

kocubinski commented Apr 17, 2024

View reviewed changes

core/transaction/transaction.go Show resolved Hide resolved

go mod tidy

b7ab61e

kocubinski commented Apr 17, 2024

View reviewed changes

server/v2/cometbft/abci.go Outdated Show resolved Hide resolved

kocubinski commented Apr 17, 2024

View reviewed changes

server/v2/cometbft/utils.go Show resolved Hide resolved

Merge branch 'server_modular' of github.com:cosmos/cosmos-sdk into ko…

46992b5

…cu/genesis-v2

github-advanced-security bot found potential problems Apr 17, 2024

View reviewed changes

tac0turtle reviewed Apr 18, 2024

View reviewed changes

server/v2/appmanager/appmanager.go Outdated Show resolved Hide resolved

kocubinski marked this pull request as ready for review April 18, 2024 14:29

kocubinski requested a review from a team as a code owner April 18, 2024 14:29

tac0turtle added 5 commits April 26, 2024 13:38

Merge branch 'server_modular' into kocu/genesis-v2

12a52c9

go mod tidy

ab6d7aa

conflict

fe760b7

conflict

8a404fd

minor cleanup for consistency

c725900

julienrbrt reviewed Apr 26, 2024

View reviewed changes

remove auto support

8933045

github-advanced-security bot found potential problems Apr 26, 2024

View reviewed changes

runtime/v2/manager.go

return fmt.Errorf("failed to unmarshal %s genesis state: %w", moduleName, err)

}

for _, jsonTx := range genesisState.GenTxs {

txHandler(jsonTx)

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.

tac0turtle merged commit 9414353 into server_modular Apr 26, 2024
54 of 64 checks passed

tac0turtle deleted the kocu/genesis-v2 branch April 26, 2024 17:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2 genesis #20076

v2 genesis #20076

kocubinski commented Apr 17, 2024 •

edited

Loading

coderabbitai bot commented Apr 17, 2024 •

edited

Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

kocubinski Apr 17, 2024

kocubinski Apr 17, 2024

julienrbrt Apr 26, 2024

v2 genesis #20076

v2 genesis #20076

Conversation

kocubinski commented Apr 17, 2024 • edited Loading

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented Apr 17, 2024 • edited Loading

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

kocubinski Apr 17, 2024

Choose a reason for hiding this comment

kocubinski Apr 17, 2024

Choose a reason for hiding this comment

julienrbrt Apr 26, 2024

Choose a reason for hiding this comment

kocubinski commented Apr 17, 2024 •

edited

Loading

coderabbitai bot commented Apr 17, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)