test: add NodeURI for clientCtx

[mmsqe]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

Walkthrough

The recent update enhances the testutil module by integrating a new NodeURI feature into the clientCtx structure. Additionally, the New function within the network.go file has been refined to include this NodeURI, utilizing the Tendermint configuration's RPC listen address. The update also streamlines the process of setting the ConsensusAddressCodec through an improved chain of method calls.

Changes

File(s)	Summary of Changes
CHANGELOG.md	Added a summary for the new NodeURI feature in the testutil module.
.../testutil/network/network.go	Modified the New function to incorporate WithNodeURI using the tmCfg.RPC.ListenAddress and updated method call chaining for ConsensusAddressCodec.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your comments unless it is explicitly tagged.

• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

The WithConsensusAddressCodec method is incorrectly assigned cfg.ValidatorAddressCodec instead of cfg.ConsensusAddressCodec. This needs to be corrected to match the intended configuration.

- WithConsensusAddressCodec(cfg.ValidatorAddressCodec).
+ WithConsensusAddressCodec(cfg.ConsensusAddressCodec).

---

Committable suggestion

❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	WithConsensusAddressCodec(cfg.ValidatorAddressCodec).
	WithConsensusAddressCodec(cfg.ConsensusAddressCodec).

[julienrbrt]

The bot is right about this

[mmsqe]

my bad, but is it ok to port back to 0.47.x as well since we have some test need it

[julienrbrt]

You haven't introduced this, and it is only was an issue on main (address codecs aren't in the context in earlier versions).
Looks fine to backport this PR however.

[alexanderbez]

LGTM

[julienrbrt]

@mergify backport release/v0.50.x

[julienrbrt]

@mergify backport release/v0.47.x

[mergify]

backport release/v0.50.x

✅ Backports have been created

• #18987 test: add NodeURI for clientCtx (backport #18930) has been created for branch release/v0.50.x but encountered conflicts

[mergify]

backport release/v0.47.x

✅ Backports have been created

• #18988 test: add NodeURI for clientCtx (backport #18930) has been created for branch release/v0.47.x but encountered conflicts