feat: [ADR-070] Unordered Transactions (1/2) #18641
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -290,7 +290,7 @@ message TestUpdatedTxBody { | |
| repeated google.protobuf.Any messages = 1; | ||
| string memo = 2; | ||
| int64 timeout_height = 3; | ||
| uint64 some_new_field = 5; | ||
|
There was a problem hiding this comment. @facundomedica why does this fix the issue? There was a problem hiding this comment. It's because a new field was added with tag 4 to From what I understand, the rejecting of unknown fields happen by checking the tag numbers, so There was a problem hiding this comment. good find!! could you add a comment to not confuse future readers There was a problem hiding this comment. added a small comment on the test case 👌 There was a problem hiding this comment. Yeah this was such a footgun -- never would've found out. Thanks! |
||
| string some_new_field_non_critical_field = 1050; | ||
| repeated google.protobuf.Any extension_options = 1023; | ||
| repeated google.protobuf.Any non_critical_extension_options = 2047; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the field number of an existing field can break backward compatibility as serialized data will not be correctly understood by the new schema. Ensure that this change is intentional and that all consumers of this protobuf are updated accordingly.