Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix genesis bond intra-tx counter bug #1853

Merged
merged 1 commit into from
Jul 27, 2018
Merged

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jul 27, 2018

Closes #1839

  • Linked to github-issue with discussion and accepted design
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added ready-for-review T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Jul 27, 2018
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this,

Really interesting. Lesson: use extra care when placing bug fixes. The moved line of code was recently added in to resolve an old issue, which backhandedly created a new hidden issue due to improper placement.

good work Chris!

@rigelrozanski rigelrozanski merged commit 9812c88 into develop Jul 27, 2018
@rigelrozanski rigelrozanski deleted the cwgoes/staking-bugfix branch July 27, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants