Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tagged the wrong branch #18407

Merged
merged 2 commits into from
Nov 7, 2023
Merged

chore: tagged the wrong branch #18407

merged 2 commits into from
Nov 7, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 7, 2023

Description

I mistakenly tagged main instead of release/v0.50.x.
We quickly deleted the tag and then re-released, but unfortunately the go proxy had already picked that up (https://index.golang.org/index?since=2023-11-07T18:02:52.997264Z).


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • Chores
    • Temporarily disabled the release job, release-success job, and Slack notifications in the workflow configuration.

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Nov 7, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner November 7, 2023 18:48
@github-prbot github-prbot requested review from a team, kocubinski and atheeshp and removed request for a team November 7, 2023 18:49
@julienrbrt julienrbrt requested a review from tac0turtle November 7, 2023 18:50
Copy link
Contributor

coderabbitai bot commented Nov 7, 2023

Walkthrough

The changes primarily involve commenting out sections of the .github/workflows/release.yml file. This includes the workflow configuration related to tag push events, permissions, and steps for the release and release-success jobs, including the Slack notification step.

Changes

File Change Summary
.github/workflows/release.yml Commented out the workflow configuration for tag push events, permissions, and steps for the release and release-success jobs, including the Slack notification step.

Poem

🍂 On this day of change, in the heart of fall,
🐇 CodeRabbit hopped and made a call.
"Let's pause and ponder, let's take a rest,
Comment out the code, it might be best."

📜 In history, on this very date,
The magic of coding continued to create.
So let's celebrate, with a carrot feast,
For every coder, from west to east. 🥕🎉

🌍 Inclusive and kind, we hop together,
Through every line of code, in any weather.
So here's to the changes, big and small,
CodeRabbit salutes you all! 🐇🎩


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@tac0turtle tac0turtle enabled auto-merge November 7, 2023 18:54
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e2b71b7 and fae05c5.
Files ignored due to filter (1)
  • go.mod
Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)
Additional comments: 1
.github/workflows/release.yml (1)
  • 1-51: The entire release workflow has been commented out. This will prevent any releases from being triggered on tag push events. Ensure that this is the intended behavior and that a suitable alternative workflow is in place or planned.

@tac0turtle tac0turtle added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 8fbf616 Nov 7, 2023
55 of 56 checks passed
@tac0turtle tac0turtle deleted the julien/mistake branch November 7, 2023 19:20
mergify bot pushed a commit that referenced this pull request Nov 7, 2023
(cherry picked from commit 8fbf616)

# Conflicts:
#	.github/workflows/release.yml
julienrbrt added a commit that referenced this pull request Nov 7, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release Type: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants