-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding additional info on amino.encoding
proto annotations
#18274
Conversation
WalkthroughThe change provides a valuable clarification in the documentation about the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/build/building-modules/05-protobuf-annotations.md (1} hunks)
Files skipped from review due to trivial changes (1)
- docs/build/building-modules/05-protobuf-annotations.md
Description
Adding some additional info on
amino.encoding
proto annotations.Added an additional link to where the encoder is instantiated within
tx/signing/aminojson
Closes: #XXXX (nothing)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit
Encoding
field in our documentation. This update provides a better understanding of how to encode certain fields, specifically highlighting thelegacy_coins
option for encoding a null slice ofcosmos.base.v1beta1.Coin
. This will help users to correctly utilize our system and avoid potential errors.