fix(x/bank): miss keypair of SendEnabled to restore legacy param set before migration

[mmsqe]

this change was introduced in https://github.com/cosmos/cosmos-sdk/pull/11977/files, but accidently get removed in https://github.com/cosmos/cosmos-sdk/pull/12630/files, since bank send_enabled refactor before params migration

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• run make lint and make test
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

Wow, good catch (other reviewers, see https://github.com/cosmos/cosmos-sdk/pull/12630/files#diff-c58b556b8ace809b59cce155271115f96a755f2d04d3ac9368c5c58e5791bc1eL30-L36).

Given that v0.47 is already released and that it means chains have already migrated bank, I think we should have this additionally extracted as a public helper. This way, chains on v0.47 can run it in their next major upgrade (as now it won't be run for them), we'll add this in the release notes.

Another note is this should probably target v0.50 and be backported to v0.47 (main has no params migration anymore).

[yihuang]

This way, chains on v0.47 can run it in their next major upgrade (as now it won't be run for them)

The chains already on v0.47 has lost the send-enabled settings, they must get from the historical state, and recover them using the gov proposal.

[julienrbrt]

This way, chains on v0.47 can run it in their next major upgrade (as now it won't be run for them)

The chains already on v0.47 has lost the send-enabled settings, they must get from the historical state, and recover them using the gov proposal.

They can, but I believe these are still stored in x/params, so we could add a helper getting it for them.

[yihuang]

This way, chains on v0.47 can run it in their next major upgrade (as now it won't be run for them)

The chains already on v0.47 has lost the send-enabled settings, they must get from the historical state, and recover them using the gov proposal.

They can, but I believe these are still stored in x/params, so we could add a helper getting it for them.

you are right, we didn't remove the x/params store.

[julienrbrt]

Mostly lgtm, just one request :)

[julienrbrt]

Can we add an helper, that gets already migrated bank params (so current v047 users), get the send enabled params from x/params and update the bank params?
This way affected users (I've checked, found none, but just in case), can use it.

[mmsqe]

Not sure if you mean add a public helper in app module, or do you have any example I should put it in.

[julienrbrt]

This is almost what I meant, yes, but no need to have anything in AppModule.

You can keep Migrate3to4 as you had it, with the fix, and move MigrateSubspaceParams here (package keeper or v4), named MigrateSendEnabledParams with a comment explaining this is only needed for chains having migrated from <= v0.47 to v0.47.0-5

[julienrbrt]

lgtm! Thank you