Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gov): handle panics when executing x/gov proposals (backport #17780) #17793

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 18, 2023

This is an automatic backport of pull request #17780 done by Mergify.
Cherry-pick of a0b39a1 has failed:

On branch mergify/bp/release/v0.47.x/pr-17780
Your branch is up to date with 'origin/release/v0.47.x'.

You are currently cherry-picking commit a0b39a1d3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   x/gov/abci_internal_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   x/gov/abci.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit a0b39a1)

# Conflicts:
#	CHANGELOG.md
#	x/gov/abci.go
@mergify mergify bot requested a review from a team as a code owner September 18, 2023 16:16
@mergify mergify bot added the conflicts label Sep 18, 2023
@julienrbrt julienrbrt merged commit 80705f7 into release/v0.47.x Sep 18, 2023
27 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v0.47.x/pr-17780 branch September 18, 2023 20:07
mmsqe pushed a commit to mmsqe/cosmos-sdk that referenced this pull request Oct 9, 2023
…mos#17780) (cosmos#17793)

Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Mar 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants