feat(client/v2): Add clientCtx to commands in autocli
#17709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/distribution
julienrbrt
changed the title
ClientCtx to commands in autocliclientCtx to commands in autocli
|
@atheeshp your pull request is missing a changelog! |
|
Can you update app legacy and hubl? |
julienrbrt
reviewed
Sep 14, 2023
20 tasks
julienrbrt
reviewed
Sep 14, 2023
client/v2/go.mod
Outdated
| @@ -10,7 +10,7 @@ require ( | |||
| cosmossdk.io/x/tx v0.10.0 | |||
| github.com/cockroachdb/errors v1.11.1 | |||
| github.com/cosmos/cosmos-proto v1.0.0-beta.3 | |||
| github.com/cosmos/cosmos-sdk v0.46.0-beta2.0.20230718211500-1d74652f6021 | |||
| github.com/cosmos/cosmos-sdk v0.46.0-beta2.0.20230828195211-3a911572e3e1 | |||
There was a problem hiding this comment.
can we revert this? there should be no changes in the SDK
There was a problem hiding this comment.
No, we need the latest changes of hub,
cosmos-sdk/client/v2/autocli/builder.go
Line 40 in 706a531
AddressCodec is introduced in later commits of existing one.
julienrbrt
reviewed
Sep 15, 2023
julienrbrt
added
the
backport/v0.50.x
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit a0bd4e9) # Conflicts: # client/v2/go.mod # client/v2/go.sum # simapp/simd/cmd/root.go # simapp/simd/cmd/root_v2.go
julienrbrt
pushed a commit
that referenced
this pull request
Sep 15, 2023
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #17423
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change