feat(accounts): allow accounts to query and execute modules #17685
Conversation
github-prbot
requested review from
a team,
kocubinski and
alexanderbez
and removed request for
a team
|
@testinginprod your pull request is missing a changelog! |
| func (k Keeper) makeAccountContext(ctx context.Context, accountAddr, sender []byte, isQuery bool) context.Context { | ||
| // if it's not a query we create a context that allows to do anything. | ||
| if !isQuery { | ||
| return implementation.MakeAccountContext( |
There was a problem hiding this comment.
do we want to add event emission here too?
There was a problem hiding this comment.
100%, I think we progressively add services to the account, although I'll want a proxy account service which also defines which is the account emitting the event.
|
|
||
| "cosmossdk.io/core/store" | ||
| "cosmossdk.io/x/accounts/internal/prefixstore" | ||
| ) | ||
|
|
||
| var errUnauthorized = errors.New("unauthorized") |
There was a problem hiding this comment.
Do we expect callers to be able to inspect and handle errors from handlers gracefully? If so, sentinel errors should be public.
There was a problem hiding this comment.
i don't think this error will be exported since it usually means that an account intentionally or not was trying to impersonate someone else.
this is still gated behind an internal package, so when done with the implementation we can carefully pick what to re-export.
Description
Closes: #17686
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change