Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in comment #17635

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: typo in comment #17635

merged 1 commit into from
Sep 6, 2023

Conversation

bryanchriswhite
Copy link
Contributor

Description

Replaces "config.toml" with "client.toml" to avoid confusion between this and the cometbft config ("config.toml"); see: server/main/util.go:236.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@bryanchriswhite
fix: typo in comment
d79e029 
Replaces "config.toml" with "client.toml" to avoid confusion between this and the cometbft config ("config.toml"); see: [server/main/util.go:236](https://github.com/cosmos/cosmos-sdk/blob/main/server/util.go#L236).
@bryanchriswhite bryanchriswhite requested a review from a team as a code owner September 6, 2023 09:16
@julienrbrt julienrbrt added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release labels Sep 6, 2023
julienrbrt
julienrbrt approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions github-actions bot added the C:CLI label Sep 6, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Sep 6, 2023
Merged via the queue into cosmos:main with commit 01b8be0 Sep 6, 2023
44 of 46 checks passed
mergify bot pushed a commit that referenced this pull request Sep 6, 2023
@bryanchriswhite @mergify
fix: typo in comment (#17635)
d9b044f 
(cherry picked from commit 01b8be0)
mergify bot pushed a commit that referenced this pull request Sep 6, 2023
@bryanchriswhite @mergify
fix: typo in comment (#17635)
dec5706 
(cherry picked from commit 01b8be0)
mergify bot pushed a commit that referenced this pull request Sep 6, 2023
@bryanchriswhite @mergify
fix: typo in comment (#17635)
bd35e39 
(cherry picked from commit 01b8be0)

# Conflicts:
#	client/config/config.go
mergify bot pushed a commit that referenced this pull request Sep 6, 2023
@bryanchriswhite @mergify
fix: typo in comment (#17635)
e64bd8b 
(cherry picked from commit 01b8be0)

# Conflicts:
#	client/config/config.go
This was referenced Sep 6, 2023
Merged
Merged
Merged
tac0turtle added a commit that referenced this pull request Sep 6, 2023
@mergify @bryanchriswhite @tac0turtle
fix: typo in comment (backport #17635) (#17638)
f1dfe60 
Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
tac0turtle pushed a commit that referenced this pull request Sep 6, 2023
@mergify @bryanchriswhite
fix: typo in comment (backport #17635) (#17636)
59f8183 
Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
julienrbrt added a commit that referenced this pull request Sep 6, 2023
@mergify @bryanchriswhite @julienrbrt
fix: typo in comment (backport #17635) (#17637)
1dfa761 
Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Oct 15, 2023
Closed
19 tasks
rootulp pushed a commit to rootulp/cosmos-sdk that referenced this pull request Nov 7, 2023
@mergify @bryanchriswhite
@tac0turtle @rootulp
fix: typo in comment (backport cosmos#17635) (cosmos#17638)
bc88973 
Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
rootulp added a commit to celestiaorg/cosmos-sdk that referenced this pull request Nov 14, 2023
@rootulp @mergify
@mmsqe @julienrbrt @itsdevbear @devon-chain @fmorency @bryanchriswhite @tac0turtle
chore: upgrade to cosmos-sdk v0.46.16 (#357)
e04d485 
* refactor: add MigrateHandler to allow reuse migrate genesis related function  (backport cosmos#17296) (cosmos#17301)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302)

* feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357)

Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: use correct config key for db_backend (backport cosmos#17406) (cosmos#17412)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare v0.46.15 (cosmos#17408)

* fix(x/authz): GetAuthorizations (backport cosmos#17334) (cosmos#17527)

Co-authored-by: devon <80245700+devon-chain@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* docs: update x/group create-proposal to submit-proposal (backport cosmos#17544) (cosmos#17549)

Co-authored-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com>

* fix: typo in comment (backport cosmos#17635) (cosmos#17638)

Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>

* build(deps): bump cosmos/ledger-cosmos-go to v0.12.3 in v0.46 (backport cosmos#18105) (cosmos#18112)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare release notes v0.46.16 (cosmos#18118)

* fix(server): don't hardcode grpc address to localhost (backport cosmos#18254) (cosmos#18260)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: update tag date v0.46.16 (cosmos#18385)

* revert: Go 1.19

* revert: c226e8b

* chore(deps): upgrade to v1.29.0-tm-v0.34.29

* chore: downgrade to grpc 1.54.0

to match the versions used in upstream

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Devon Bear <itsdevbear@berachain.com>
Co-authored-by: devon <80245700+devon-chain@users.noreply.github.com>
Co-authored-by: Félix C. Morency <1102868+fmorency@users.noreply.github.com>
Co-authored-by: Bryan White <bryanchriswhite@gmail.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
@faddat faddat mentioned this pull request Mar 20, 2024
Open
12 tasks
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanchriswhite @tac0turtle @julienrbrt