Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): use address codec #17503

Merged
merged 15 commits into from
Aug 23, 2023
Merged

refactor(client): use address codec #17503

merged 15 commits into from
Aug 23, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 22, 2023

Description

Follow-up: #17107

Use address codec whenever possible in client.
This does not modify module client code as it will be deleted for AutoCLI.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels Aug 22, 2023
@julienrbrt julienrbrt marked this pull request as ready for review August 22, 2023 16:49
@julienrbrt julienrbrt requested a review from a team as a code owner August 22, 2023 16:49
@julienrbrt
Copy link
Member Author

I'll fix the tests and changelogs and upgrading.md if people agree this is fine.

@julienrbrt julienrbrt mentioned this pull request Aug 22, 2023
20 tasks
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seems to be providing context with necessary address codecs for client. Making sense to me.

@julienrbrt julienrbrt added this pull request to the merge queue Aug 23, 2023
Merged via the queue into main with commit c6b0bb6 Aug 23, 2023
48 of 50 checks passed
@julienrbrt julienrbrt deleted the julien/keyring-bech32 branch August 23, 2023 10:45
@julienrbrt julienrbrt mentioned this pull request Aug 24, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants