Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable TestStatusCommand #17452

Merged
merged 1 commit into from
Aug 19, 2023
Merged

test: disable TestStatusCommand #17452

merged 1 commit into from
Aug 19, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref: #17446

Temporarily disable this test as it blocks PRs 95% of the time.
#17443 got 0 pass of that test yet, blocking the PR.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner August 18, 2023 20:48
@github-prbot github-prbot requested review from a team, facundomedica and testinginprod and removed request for a team August 18, 2023 20:48
@github-actions github-actions bot added the C:CLI label Aug 18, 2023
@julienrbrt julienrbrt enabled auto-merge August 18, 2023 20:48
@julienrbrt julienrbrt added this pull request to the merge queue Aug 19, 2023
Merged via the queue into main with commit 37b8760 Aug 19, 2023
@julienrbrt julienrbrt deleted the julien/disable-status-test branch August 19, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants