Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Revert RunMigrationBeginBlock addition in v0.50 #17450

Merged
merged 7 commits into from
Aug 18, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 18, 2023

Description

Partially reverts 6a5adc4
Reverts 3a96bb9
Reverts 27f5db2

cc @mmsqe

Last blocker before v0.50 rc release.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title Revert RunMigrationBeginBlock introduction revert: Revert RunMigrationBeginBlock introduction Aug 18, 2023
@julienrbrt julienrbrt marked this pull request as ready for review August 18, 2023 16:30
@julienrbrt julienrbrt requested a review from a team as a code owner August 18, 2023 16:30
@github-prbot github-prbot requested a review from a team August 18, 2023 16:32
@mmsqe
Copy link
Contributor

mmsqe commented Aug 18, 2023

Thanks for the cleanup, not sure if we still keep this in doc

* [`appmodule.UpgradeModule`]: The extension interface that signify if the `AppModule` if the module is an upgrade module.

@julienrbrt
Copy link
Member Author

Thanks for the cleanup, not sure if we still keep this in doc

* [`appmodule.UpgradeModule`]: The extension interface that signify if the `AppModule` if the module is an upgrade module.

Good catch!

@julienrbrt julienrbrt changed the title revert: Revert RunMigrationBeginBlock introduction revert: Revert RunMigrationBeginBlock addition in v0.50 Aug 18, 2023
if err := module.BeginBlock(ctx); err != nil {
return sdk.BeginBlock{}, err
}
if err := module.BeginBlock(ctx); err != nil {

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

path flow from Begin/EndBlock to a panic call path flow from Begin/EndBlock to a panic call path flow from Begin/EndBlock to a panic call path flow from Begin/EndBlock to a panic call path flow from Begin/EndBlock to a panic call
@julienrbrt julienrbrt enabled auto-merge (squash) August 18, 2023 18:44
@github-actions github-actions bot added the C:CLI label Aug 18, 2023
@julienrbrt julienrbrt merged commit b7d9d4c into release/v0.50.x Aug 18, 2023
@julienrbrt julienrbrt deleted the julien/revert-upgrade branch August 18, 2023 20:48
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants