feat: add apphash to process proposal calls #17401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consistent with finalize block calls
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
483
to
489
| Time: req.Time, | ||
| ProposerAddress: req.ProposerAddress, | ||
| NextValidatorsHash: req.NextValidatorsHash, | ||
| AppHash: app.LastCommitID().Hash, | ||
| } | ||
| app.setState(execModeProcessProposal, header) | ||
|
|
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).ProcessProposal (baseapp/abci.go:467)
julienrbrt
changed the title
tac0turtle
reviewed
Aug 16, 2023
Comment on lines
400
to
406
| Time: req.Time, | ||
| ProposerAddress: req.ProposerAddress, | ||
| NextValidatorsHash: req.NextValidatorsHash, | ||
| AppHash: app.LastCommitID().Hash, | ||
| } | ||
| app.setState(execModePrepareProposal, header) | ||
|
|
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).PrepareProposal (baseapp/abci.go:390)
alexanderbez
added
the
backport/v0.50.x
mergify bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> (cherry picked from commit a860919)
tac0turtle
pushed a commit
that referenced
this pull request
Aug 17, 2023
samricotta
pushed a commit
that referenced
this pull request
Aug 19, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consistent with finalize block calls
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change