Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client/v2): add key lookup interface #17308

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

ref: #14744

#17306 should be merged before.

Add simple keyring interface (to be expended in follow-ups) and wiring it in address flags handlers.
It allows using a key name instead of any addresses in queries/tx.

I'll wire this in the SDK in a follow-up.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 7, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner August 7, 2023 13:40
@github-actions github-actions bot added the C:CLI label Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

@julienrbrt your pull request is missing a changelog!

@julienrbrt
Copy link
Member Author

@julienrbrt your pull request is missing a changelog!

client/v2 does not have any changelog.

Base automatically changed from julien/autocli-tx to main August 7, 2023 13:55
@julienrbrt julienrbrt requested review from a team, facundomedica and atheeshp and removed request for a team August 7, 2023 14:17
@julienrbrt julienrbrt added this pull request to the merge queue Aug 8, 2023
Merged via the queue into main with commit f14f421 Aug 8, 2023
@julienrbrt julienrbrt deleted the julien/autocli-tx-2 branch August 8, 2023 10:21
mergify bot pushed a commit that referenced this pull request Aug 8, 2023
julienrbrt added a commit that referenced this pull request Aug 8, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants