-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: speed up lint job #17071
ci: speed up lint job #17071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to make sure when we deprecate something that the author or reviewer runs the long version locally
It seems then that maybe it is then beneficial to keep running it all the time in CI. 🤔 |
69173d0
to
ae519dc
Compare
7653af4
to
ae519dc
Compare
.github/workflows/lint.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use a bigger runner, but it didn't work. Once we figure out how to use bigger runner, we can revert this and use the bigger runner instead.
9a006e3
to
4ab4a57
Compare
(cherry picked from commit 3bbc370) # Conflicts: # .golangci.yml # Makefile
Description
Closes: #16240
Should speed up the run from ≃ 15min to some seconds-2min depending on the PR.
When we bump or change golangci-lint config, it will run on the whole codebase.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change