docs: clarify software upgrade proposals are legacy #16954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
alexanderbez and
samricotta
and removed request for
a team
julienrbrt
approved these changes
Jul 12, 2023
julienrbrt
added
the
backport/v0.50.x
julienrbrt
changed the title
alexanderbez
approved these changes
Jul 12, 2023
Comment on lines
+12
to
+14
| // NewSoftwareUpgradeProposal creates a new SoftwareUpgradeProposal instance. | ||
| // Deprecated: this proposal is considered legacy and is deprecated in favor of | ||
| // Msg-based gov proposals. See MsgSoftwareUpgrade. |
There was a problem hiding this comment.
Suggested change
| // NewSoftwareUpgradeProposal creates a new SoftwareUpgradeProposal instance. | |
| // Deprecated: this proposal is considered legacy and is deprecated in favor of | |
| // Msg-based gov proposals. See MsgSoftwareUpgrade. | |
| // NewSoftwareUpgradeProposal creates a new SoftwareUpgradeProposal instance. | |
| // | |
| // Deprecated: this proposal is considered legacy and is deprecated in favor of | |
| // Msg-based gov proposals. See MsgSoftwareUpgrade. |
Comment on lines
+47
to
+49
| // NewCancelSoftwareUpgradeProposal creates a new CancelSoftwareUpgradeProposal | ||
| // instance. Deprecated: this proposal is considered legacy and is deprecated in | ||
| // favor of Msg-based gov proposals. See MsgCancelUpgrade. |
There was a problem hiding this comment.
Suggested change
| // NewCancelSoftwareUpgradeProposal creates a new CancelSoftwareUpgradeProposal | |
| // instance. Deprecated: this proposal is considered legacy and is deprecated in | |
| // favor of Msg-based gov proposals. See MsgCancelUpgrade. | |
| // NewCancelSoftwareUpgradeProposal creates a new CancelSoftwareUpgradeProposal | |
| // instance. | |
| // | |
| // Deprecated: this proposal is considered legacy and is deprecated in | |
| // favor of Msg-based gov proposals. See MsgCancelUpgrade. |
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
(cherry picked from commit 3f4563e)
julienrbrt
pushed a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: #16929 (comment)
Inspiration for comments is from here and here.