Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: print the value initialStake instead of its pointer #16951

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

ggrieco-tob
Copy link
Contributor

@ggrieco-tob ggrieco-tob commented Jul 12, 2023

Description

This small change ensure that the debug print shows the value of initialStake instead of its pointer.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@ggrieco-tob ggrieco-tob requested a review from a team as a code owner July 12, 2023 12:23
@github-prbot github-prbot requested review from a team, kocubinski and tac0turtle and removed request for a team July 12, 2023 12:23
@ggrieco-tob
Copy link
Contributor Author

Hi!

This is my first PR. I'm wondering if:

  • Should I create an issue to address?
  • Is it necessary to edit the CHANGELOG.md for such a small change?
  • Is there something to document?

@julienrbrt
Copy link
Member

Hi!

This is my first PR. I'm wondering if:

  • Should I create an issue to address?
  • Is it necessary to edit the CHANGELOG.md for such a small change?
  • Is there something to document?

Hi, thank you for your PR!

  1. Normally yes, but given that it is a small change, and you have explained what it does and the reason of the change in the description, this is ok. Thank you for that.
  2. Same as above :)
  3. Nope

@ggrieco-tob
Copy link
Contributor Author

ggrieco-tob commented Jul 12, 2023

Thanks for the quick response! I'm still waiting for the CI to finish, but after that should be good to review.

@ggrieco-tob
Copy link
Contributor Author

It seems that the linter test failed:

API rate limit exceeded for installation ID 5766626.

Can someone from the team re-run that test later?

@facundomedica facundomedica enabled auto-merge July 13, 2023 08:05
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 13, 2023
@facundomedica facundomedica added this pull request to the merge queue Jul 13, 2023
Merged via the queue into cosmos:main with commit b1ac576 Jul 13, 2023
mergify bot pushed a commit that referenced this pull request Jul 13, 2023
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
(cherry picked from commit b1ac576)
julienrbrt pushed a commit that referenced this pull request Jul 13, 2023
…16951) (#16975)

Co-authored-by: Gustavo Grieco <31542053+ggrieco-tob@users.noreply.github.com>
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants