-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert f235aae (part 2) #16697
fix: revert f235aae (part 2) #16697
Conversation
what is the error causing the issue? |
grpcurl still supports reflection v1beta1 only and grpcui as well (https://github.com/search?q=repo%3Afullstorydev%2Fgrpcui%20NewClient&type=code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense, need to add nolint or add the rule to golangci.yaml
(cherry picked from commit a067ef6)
Co-authored-by: Julien Robert <julien@rbrt.fr>
Description
When testing the server changes (ref #16698), I have noticed that grpcui and grpcurl were broken because of that update.
follow-up of #16534.
I think we should strive for compatibility and still revert f235aae as well for the SDK.
cc @tac0turtle as you were involved in the discussion in #16534
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change