Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(staking): add autocli query cmd #16641

Merged
merged 11 commits into from
Jul 7, 2023
Merged

feat(staking): add autocli query cmd #16641

merged 11 commits into from
Jul 7, 2023

Conversation

JeancarloBarrios
Copy link
Contributor

Description

ref: #15901

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JeancarloBarrios JeancarloBarrios mentioned this pull request Jun 22, 2023
Closed
17 tasks
@github-actions github-actions bot added the C:CLI label Jun 23, 2023
@JeancarloBarrios JeancarloBarrios marked this pull request as ready for review June 25, 2023 22:35
@JeancarloBarrios JeancarloBarrios requested a review from a team as a code owner June 25, 2023 22:35
@github-prbot github-prbot requested review from a team, alexanderbez and tac0turtle and removed request for a team June 25, 2023 22:35
@github-actions
Copy link
Contributor

@JeancarloBarrios your pull request is missing a changelog!

julienrbrt
julienrbrt reviewed Jun 25, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you check that the test coverage is staying equivalent?

x/staking/autocli.go Show resolved Hide resolved
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 27, 2023
@julienrbrt
Copy link
Member

The last commit name does not correspond to what the commit did. Is the coverage identical?

julienrbrt
julienrbrt requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commands with a validator address do not work, some issue with pubkeys display as well it seems.

x/staking/autocli.go Show resolved Hide resolved
x/staking/autocli.go Show resolved Hide resolved
x/staking/autocli.go Show resolved Hide resolved
x/staking/autocli.go Show resolved Hide resolved
This was referenced Jun 28, 2023
Closed
Closed
@julienrbrt julienrbrt added the S:blocked Status: Blocked label Jun 30, 2023
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Jul 7, 2023
@julienrbrt julienrbrt enabled auto-merge July 7, 2023 15:27
@julienrbrt julienrbrt added this pull request to the merge queue Jul 7, 2023
Merged via the queue into main with commit 5aaadf7 Jul 7, 2023
@julienrbrt julienrbrt deleted the JeancarloBarrios/add-autocli-staking branch July 7, 2023 15:50
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
@JeancarloBarrios @mergify
feat(staking): add autocli query cmd (#16641)
7055379 
Co-authored-by: Julien Robert <julien@rbrt.fr>
(cherry picked from commit 5aaadf7)

# Conflicts:
#	x/staking/client/cli/query.go
@mergify mergify bot mentioned this pull request Jul 7, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 7, 2023
@mergify @JeancarloBarrios @julienrbrt
feat(staking): add autocli query cmd (backport #16641) (#16884)
4762a2f 
Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeancarloBarrios @julienrbrt