-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): add positional optional to client v2 (backport #16316) #16615
feat(client): add positional optional to client v2 (backport #16316) #16615
Conversation
Co-authored-by: Julien Robert <julien@rbrt.fr> (cherry picked from commit e078f1a) # Conflicts: # simapp/go.mod # simapp/go.sum # tests/go.mod # tests/go.sum
i dont think this needs to be backported because the changes are in their own go.mods |
api changes do not but client/v2 changes still need to be backport as it imports the SDK. |
@@ -13,15 +13,15 @@ require ( | |||
cosmossdk.io/store v0.1.0-alpha.1.0.20230606190835-3e18f4088b2c | |||
github.com/cometbft/cometbft v0.38.0-rc1 | |||
github.com/cosmos/cosmos-proto v1.0.0-beta.3 | |||
github.com/cosmos/cosmos-sdk v0.46.0-beta2.0.20230616095813-1111e0b51118 | |||
github.com/cosmos/cosmos-sdk v0.50.0-alpha.0.0.20230619222503-1fb9c870c960 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is updated because it should point to a release branch pseudo version instead of from main.
This is an automatic backport of pull request #16316 done by Mergify.
Cherry-pick of e078f1a has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com