Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(baseapp): add setter for circuit breaker (backport) #16290

Merged
merged 3 commits into from
May 26, 2023

Conversation

tac0turtle
Copy link
Member

Description

ref #14226

add baseapp setter for circuit breaker


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the base branch from main to release/v0.47.x May 25, 2023 12:27
@tac0turtle tac0turtle marked this pull request as ready for review May 25, 2023 12:27
@tac0turtle tac0turtle requested a review from a team as a code owner May 25, 2023 12:27
@tac0turtle tac0turtle changed the title Marko/circuit baseapp setter 0.47 backport: add baseapp setter for circuit breaker May 25, 2023
@julienrbrt
Copy link
Member

Can we get a changelog for this too?

@julienrbrt julienrbrt changed the title backport: add baseapp setter for circuit breaker feat(baseapp): add setter for circuit breaker (backport) May 25, 2023
Copy link
Contributor

@samricotta samricotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julienrbrt julienrbrt enabled auto-merge (squash) May 26, 2023 12:13
@julienrbrt julienrbrt merged commit 41a32fe into release/v0.47.x May 26, 2023
@julienrbrt julienrbrt deleted the marko/circuit_baseapp_setter_0.47 branch May 26, 2023 12:35
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
kakysha pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants