-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: returned errors instead of panicing in auth #16212
Conversation
tysm for this! Are you using a code formatter? Please make sure it's well configured, there are many lines that aren't formatted like |
x/bank/keeper/send.go
Outdated
if !accExists { | ||
defer telemetry.IncrCounter(1, "new", "account") | ||
k.ak.SetAccount(ctx, k.ak.NewAccountWithAddress(ctx, toAddr)) | ||
newAcc,_:= k.ak.NewAccountWithAddress(ctx, toAddr) | ||
k.ak.SetAccount(ctx,newAcc) |
Check warning
Code scanning / gosec
Errors unhandled.
x/bank/keeper/send.go
Outdated
if !accExists { | ||
defer telemetry.IncrCounter(1, "new", "account") | ||
k.ak.SetAccount(ctx, k.ak.NewAccountWithAddress(ctx, outAddress)) | ||
newAcc,_:= k.ak.NewAccountWithAddress(ctx, outAddress) | ||
k.ak.SetAccount(ctx,newAcc) |
Check warning
Code scanning / gosec
Errors unhandled.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Issue is about returning errors instead of panicing in keeper methods in auth module and changed the keeper methods and its signatures
ref: #15555
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change