Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/cosmos/gogoproto from 1.4.8 to 1.4.9 #16030

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 4, 2023

Bumps github.com/cosmos/gogoproto from 1.4.8 to 1.4.9.

Changelog

Sourced from github.com/cosmos/gogoproto's changelog.

v1.4.9 - 2023-05-03

Breaking changes

  • #62 Change public API for MergedFileDescriptors, MergedGlobalFileDescriptors, etc. introduced in v1.4.8, retracting that release.

Improvements

  • #62 Add the proto.HybridResolver var which exposes the merged *protoregistry.Files functionality in a high-performance way. Also add the proto.GogoResolver var.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/cosmos/gogoproto](https://github.com/cosmos/gogoproto) from 1.4.8 to 1.4.9.
- [Release notes](https://github.com/cosmos/gogoproto/releases)
- [Changelog](https://github.com/cosmos/gogoproto/blob/main/CHANGELOG.md)
- [Commits](cosmos/gogoproto@v1.4.8...v1.4.9)

---
updated-dependencies:
- dependency-name: github.com/cosmos/gogoproto
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner May 4, 2023 04:04
@dependabot dependabot bot added A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file testing-required labels May 4, 2023
@github-actions github-actions bot added C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Rosetta Issues and PR related to Rosetta labels May 4, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: proto: file "google/protobuf/any.proto" already registered
WARNING: proto: file name query.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name testdata.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name tx.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names
WARNING: proto: file name unknonwnproto.proto does not start with expected testdata/; please make sure your folder structure matches the proto files fully-qualified names

We get this when building running simapp with v0.47

@julienrbrt
Copy link
Member

WARNING: proto: file "google/protobuf/any.proto" already registered

I'll fix the file directory here, but I have just noticed that we get this one on main as well (cc @aaronc)

@julienrbrt julienrbrt self-assigned this May 4, 2023
@julienrbrt
Copy link
Member

I am going to have to cherry-pick #14991 here.

@julienrbrt
Copy link
Member

Given the non usage of MergedRegistry in v0.47, and the big diff #14991 is bringing. I think we should skip this version.

@julienrbrt julienrbrt closed this May 9, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 9, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@julienrbrt
Copy link
Member

@dependabot ignore this minor version

@dependabot dependabot bot deleted the dependabot/go_modules/release/v0.47.x/github.com/cosmos/gogoproto-1.4.9 branch May 9, 2023 14:39
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 9, 2023

OK, I won't notify you about version 1.4.x again, unless you re-open this PR. 😢

@julienrbrt
Copy link
Member

Now the question is if it will still notify us for main (as we still want that 😅)

@julienrbrt julienrbrt restored the dependabot/go_modules/release/v0.47.x/github.com/cosmos/gogoproto-1.4.9 branch May 9, 2023 15:46
@julienrbrt julienrbrt reopened this May 9, 2023
@julienrbrt
Copy link
Member

Re-opening as we probably do not want a retracted version as dependency.

(cherry picked from commit a90569c)

# Conflicts:
#	.golangci.yml
#	CHANGELOG.md
#	simapp/app.go
#	simapp/app_v2.go
#	testutil/assert_helpers.go
#	testutil/testdata/testpb/pulsar_query.go
#	testutil/testdata/testpb/query_grpc.pb.go
#	testutil/testdata/testpb/tx_grpc.pb.go
#	x/auth/ante/testutil_test.go
@julienrbrt
Copy link
Member

Blocked on #16083

@julienrbrt julienrbrt changed the base branch from release/v0.47.x to mergify/bp/release/v0.47.x/pr-14991 May 10, 2023 12:40
…_modules/release/v0.47.x/github.com/cosmos/gogoproto-1.4.9
@julienrbrt
Copy link
Member

Alright, everything is fixed, we are only getting the same as for main: #16030 (comment) (which should still be investigated separately).

@julienrbrt julienrbrt removed their assignment May 10, 2023
Base automatically changed from mergify/bp/release/v0.47.x/pr-14991 to release/v0.47.x May 10, 2023 16:38
@julienrbrt julienrbrt merged commit 85fc4af into release/v0.47.x May 10, 2023
@julienrbrt julienrbrt deleted the dependabot/go_modules/release/v0.47.x/github.com/cosmos/gogoproto-1.4.9 branch May 10, 2023 16:42
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
…smos#16030)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
kakysha pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Aug 15, 2023
…smos#16030)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Rosetta Issues and PR related to Rosetta dependencies Pull requests that update a dependency file S:blocked Status: Blocked testing-required
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants