refactor(core): abci 2.0 integration #15960
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| app.FinalizeBlock(context.TODO(), &abci.RequestFinalizeBlock{ | ||
| Height: app.LastBlockHeight() + 1, | ||
| AppHash: app.LastCommitID().Hash, | ||
| ValidatorsHash: valSet.Hash(), | ||
| NextValidatorsHash: valSet.Hash(), | ||
| }}) | ||
| }) |
Check warning
Code scanning / gosec
Errors unhandled.
| ) | ||
|
|
||
| // commit genesis changes | ||
| if !startupConfig.AtGenesis { | ||
| app.Commit() | ||
| app.BeginBlock(abci.RequestBeginBlock{Header: cmtproto.Header{ | ||
| app.Commit(context.TODO(), &abci.RequestCommit{}) |
Check warning
Code scanning / gosec
Errors unhandled.
| bApp.InitChain(cmtabcitypes.RequestInitChain{ChainId: appName}) | ||
| bApp.Commit() | ||
| bApp.InitChain(context.Background(), &cmtabcitypes.RequestInitChain{ChainId: appName}) | ||
| bApp.Commit(context.TODO(), &cmtabcitypes.RequestCommit{}) |
Check warning
Code scanning / gosec
Errors unhandled.
| @@ -71,8 +71,8 @@ | |||
| panic(fmt.Errorf("failed to load application version from store: %w", err)) | |||
| } | |||
|
|
|||
| bApp.InitChain(cmtabcitypes.RequestInitChain{ChainId: appName}) | |||
| bApp.Commit() | |||
| bApp.InitChain(context.Background(), &cmtabcitypes.RequestInitChain{ChainId: appName}) | |||
Check warning
Code scanning / gosec
Errors unhandled.
| @@ -127,8 +134,11 @@ | |||
| require.Nil(t, res) | |||
| } | |||
|
|
|||
| app.EndBlock(types2.RequestEndBlock{}) | |||
| app.Commit() | |||
| app.Commit(context.TODO(), &types2.RequestCommit{}) | |||
Check warning
Code scanning / gosec
Errors unhandled.
| // app.BeginBlock(types2.RequestBeginBlock{Header: header}) | ||
| // gInfo, res, err := app.SimDeliver(txCfg.TxEncoder(), tx) | ||
|
|
||
| bz, err := txCfg.TxEncoder()(tx) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
| func (a *App) BeginBlocker(ctx sdk.Context, req abci.RequestBeginBlock) (abci.ResponseBeginBlock, error) { | ||
| return a.ModuleManager.BeginBlock(ctx, req) | ||
| func (a *App) BeginBlocker(ctx sdk.Context) (sdk.BeginBlock, error) { | ||
| return a.ModuleManager.BeginBlock(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
tac0turtle
force-pushed
the
marko/abci-2.0-3
branch
from
c078394
to
acdf141
Compare
tac0turtle
force-pushed
the
marko/abci-2.0-4
branch
from
3f3258e
to
86ec7ef
Compare
| ValidatorsHash: valSet.Hash(), | ||
| NextValidatorsHash: valSet.Hash(), | ||
| }}) | ||
| app.Commit(context.TODO(), &abci.RequestCommit{}) |
Check warning
Code scanning / gosec
Errors unhandled.
| return appBuilder.app.BaseApp.DeliverTx(tx) | ||
| } | ||
| } | ||
| // func ProvideDeliverTx(appBuilder *AppBuilder) func(abci.RequestDeliverTx) abci.ResponseDeliverTx { // TODO: what to do here? |
There was a problem hiding this comment.
doing this here #15999
Description
integrates abci2.0 outside of baseapp
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change