refactor(baseapp): set vote info to latest votes #15930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronc
reviewed
Apr 24, 2023
| @@ -341,7 +341,7 @@ func (app *BaseApp) ProcessProposal(req abci.RequestProcessProposal) (resp abci. | |||
| app.setState(runTxProcessProposal, emptyHeader) | |||
|
|
|||
| app.processProposalState.ctx = app.getContextForProposal(app.processProposalState.ctx, req.Height). | |||
| WithVoteInfos(app.voteInfos). | |||
| WithVoteInfos(req.ProposedLastCommit.Votes). // this is a set of votes that are not finalized yet, wait for commit | |||
There was a problem hiding this comment.
Why can't we just straight up remove VoteInfo from context?
There was a problem hiding this comment.
We could, but that's orthogonal, no?
There was a problem hiding this comment.
There may not be a usecase for this today but for things like optimistic execution it will be needed. Might as well leave it
EDIT: it could be removed but this would be a larger breaking chnage. I would be up for removing it in cometinfo pr though.
There was a problem hiding this comment.
im worried about backporting this if anyone is using votes, it could cause unforseen changes. Lets leave it for 0.50. Ill add a changelog then merge
There was a problem hiding this comment.
How would it be used for optimistic execution?
alexanderbez
approved these changes
Apr 24, 2023
| @@ -341,7 +341,7 @@ func (app *BaseApp) ProcessProposal(req abci.RequestProcessProposal) (resp abci. | |||
| app.setState(runTxProcessProposal, emptyHeader) | |||
|
|
|||
| app.processProposalState.ctx = app.getContextForProposal(app.processProposalState.ctx, req.Height). | |||
| WithVoteInfos(app.voteInfos). | |||
| WithVoteInfos(req.ProposedLastCommit.Votes). // this is a set of votes that are not finalized yet, wait for commit | |||
There was a problem hiding this comment.
We could, but that's orthogonal, no?
|
@tac0turtle this should be backported to 0.47 I think. |
bizk
added a commit
to Zondax/cosmos-sdk
that referenced
this pull request
Apr 25, 2023
* solved lint issues * feat(x/tx): API improvements (cosmos#15871) * refactor(baseapp): set vote info to latest votes (cosmos#15930) * refactor(staking, slashing, signing, misc): remove aliases from types/math.go (cosmos#15902) * fix(autocli): fix simapp enhancing (cosmos#15906) * fix lint on armor.go * ran make lint-fix --------- Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
github-actions bot
pushed a commit
to Zondax/cosmos-sdk
that referenced
this pull request
Apr 25, 2023
* solved lint issues * feat(x/tx): API improvements (cosmos#15871) * refactor(baseapp): set vote info to latest votes (cosmos#15930) * refactor(staking, slashing, signing, misc): remove aliases from types/math.go (cosmos#15902) * fix(autocli): fix simapp enhancing (cosmos#15906) * fix lint on armor.go * ran make lint-fix --------- Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
cool-develope
pushed a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr sets the latest votes to voteinfo in prepare and process proposal. The Prepare Proposal step introduced a conversion from ExtendedCommitInfo to abci.VoteInfo.
The ExtendedVoteInfo is meant to be used with vote extensions which are not handled yet
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change