Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(depinject): explain need appmodule.Module interface #15880

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

julienrbrt
Copy link
Member

Description

Some users missed implementing the appmodule.AppModule interface when using depinject.
This fails to give any clear error, this PR improves the docs for avoiding that.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner April 19, 2023 07:23
@julienrbrt julienrbrt changed the title docs(depinject): add step for explaining the need to implement appmodule.Module interface docs(depinject): explain need appmodule.Module interface Apr 19, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Apr 19, 2023
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Apr 19, 2023
Merged via the queue into main with commit aa68324 Apr 19, 2023
@tac0turtle tac0turtle deleted the julien/depinject-impv branch April 19, 2023 07:43
mergify bot pushed a commit that referenced this pull request Apr 19, 2023
julienrbrt added a commit that referenced this pull request Apr 19, 2023
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants