Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: signmode textual audit fixes #15715

Merged
merged 27 commits into from
Apr 23, 2023
Merged

chore: signmode textual audit fixes #15715

merged 27 commits into from
Apr 23, 2023

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Apr 5, 2023

Description

Waiting for #15550 to get merged first, although those changes have been pulled here already to make it r4r faster.

All these changes are small things related to code linting, style, docs, etc. No big issues found.

  • Use messageValueRenderer's header() instead of fmt.Sprintf("%s object", internalMsg.ProtoReflect().Descriptor().Name()). It's the same thing given that the descriptor is stored in the value renderer and then header() returns fmt.Sprintf("%s object", mr.msgDesc.Name()).
  • In GetSignBytes use NewTxValueRenderer instead of getting it through GetMessageValueRenderer .
  • Remove unnecessary interface checks
  • Fix names, use existing variables instead of raw structs for nilValue, other misc fixes
  • Added a couple tests.

Yet to be solved:

  • Check if MessageValueRenderer formatRepeated could conform to the RepeatedValueRenderer interface

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/tx label Apr 5, 2023
@facundomedica facundomedica marked this pull request as ready for review April 17, 2023 22:39
@facundomedica facundomedica requested a review from a team as a code owner April 17, 2023 22:39
@github-prbot github-prbot requested review from a team and removed request for a team April 17, 2023 22:39
@facundomedica facundomedica requested a review from JimLarson April 21, 2023 17:35
x/tx/signing/textual/any.go Outdated Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@julienrbrt julienrbrt added this pull request to the merge queue Apr 23, 2023
Merged via the queue into main with commit f001824 Apr 23, 2023
@julienrbrt julienrbrt deleted the facu/textual-audit branch April 23, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants