Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: correctly annotate validator and consensus address fields #15710

Merged
merged 9 commits into from
Apr 20, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Apr 5, 2023

Description

Ref: #11275
Ref: #15874

This PR attempts to correctly label validator and consensus address string usage but it is not exhaustive. We need to do a deeper dive in distribution, slashing, and staking to find all usages of these addresses. In particular I know I am missing several cases in x/staking. This PR, however, provides what is needed for #11275 plus some.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc changed the title fix!: correctly label validator addresses ValidatorAddressString fix!: correctly annotate validator and consensus address fields Apr 18, 2023
@aaronc aaronc marked this pull request as ready for review April 18, 2023 18:24
@aaronc aaronc requested a review from a team as a code owner April 18, 2023 18:24
@aaronc aaronc requested a review from kocubinski April 18, 2023 18:24
@github-prbot github-prbot requested review from a team and samricotta and removed request for a team April 18, 2023 18:24
@github-actions
Copy link
Contributor

@aaronc your pull request is missing a changelog!

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
This should be described in #15548 as well (cc @tac0turtle).

@aaronc aaronc enabled auto-merge April 20, 2023 16:38
@aaronc aaronc added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 654f26e Apr 20, 2023
@aaronc aaronc deleted the aaronc/fix-val-address-scalars branch April 20, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants