-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove unnecessary depinject usage #15529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Keys
Keybase, KMS and HSMs
C:Simulations
C:x/auth
labels
Mar 23, 2023
github-actions
bot
added
C:x/evidence
C:x/feegrant
C:x/group
C:x/params
C:x/slashing
labels
Mar 23, 2023
julienrbrt
force-pushed
the
julien/remove-some-depinject-usage
branch
from
March 23, 2023 14:34
a792acc
to
94e902a
Compare
julienrbrt
commented
Mar 23, 2023
@@ -201,7 +201,7 @@ func TestAllocateTokensTruncation(t *testing.T) { | |||
Address: valConsPk1.Address(), | |||
Power: 10, | |||
} | |||
abciValС := abci.Validator{ | |||
abciValC := abci.Validator{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VSCode said that С and C are different characters.
Personally I cannot see it :D
julienrbrt
changed the title
refactor: remove some depinject usage
refactor: remove unnecessary depinject usage
Mar 23, 2023
alexanderbez
approved these changes
Mar 23, 2023
tac0turtle
approved these changes
Mar 23, 2023
kocubinski
approved these changes
Mar 23, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:CLI
C:Keys
Keybase, KMS and HSMs
C:Simulations
C:x/auth
C:x/authz
C:x/distribution
distribution module related
C:x/evidence
C:x/feegrant
C:x/group
C:x/params
C:x/slashing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was doing that when refactoring some tests due to my incoming integration tests PR refactoring.
This removes the usage of
depinject.Inject
where a simple helper function can do the same.The goal is to eventually be able to only keep the usage of module's
AppConfig
when creating a minimal app with simtestutil.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change