Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary depinject usage #15529

Merged
merged 6 commits into from
Mar 23, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 23, 2023

Description

I was doing that when refactoring some tests due to my incoming integration tests PR refactoring.
This removes the usage of depinject.Inject where a simple helper function can do the same.
The goal is to eventually be able to only keep the usage of module's AppConfig when creating a minimal app with simtestutil.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner March 23, 2023 14:26
@github-prbot github-prbot requested a review from a team March 23, 2023 14:26
@github-prbot github-prbot removed the request for review from a team March 23, 2023 14:26
@github-prbot github-prbot requested a review from amaury1093 March 23, 2023 14:26
@github-actions github-actions bot added the C:x/distribution distribution module related label Mar 23, 2023
@github-prbot github-prbot requested a review from tac0turtle March 23, 2023 14:26
@julienrbrt julienrbrt force-pushed the julien/remove-some-depinject-usage branch from a792acc to 94e902a Compare March 23, 2023 14:34
@@ -201,7 +201,7 @@ func TestAllocateTokensTruncation(t *testing.T) {
Address: valConsPk1.Address(),
Power: 10,
}
abciValС := abci.Validator{
abciValC := abci.Validator{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode said that С and C are different characters.
Personally I cannot see it :D

@julienrbrt julienrbrt changed the title refactor: remove some depinject usage refactor: remove unnecessary depinject usage Mar 23, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) March 23, 2023 15:40
@julienrbrt julienrbrt merged commit 460bd0a into main Mar 23, 2023
@julienrbrt julienrbrt deleted the julien/remove-some-depinject-usage branch March 23, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants