chore: clean-up after go-plugin system pr #15402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Confix
julienrbrt
commented
Mar 14, 2023
| @@ -23,7 +22,7 @@ const ( | |||
| ) | |||
|
|
|||
| // RegisterStreamingServices registers streaming services with the BaseApp. | |||
| func (app *BaseApp) RegisterStreamingServices(appOpts servertypes.AppOptions, keys map[string]*storetypes.KVStoreKey) { | |||
| func (app *BaseApp) RegisterStreamingServices(appOpts servertypes.AppOptions, keys map[string]*storetypes.KVStoreKey) error { | |||
There was a problem hiding this comment.
julienrbrt
commented
Mar 14, 2023
| @@ -219,7 +219,7 @@ func (app *BaseApp) BeginBlock(req abci.RequestBeginBlock) (res abci.ResponseBeg | |||
| for _, abciListener := range app.streamingManager.ABCIListeners { | |||
| ctx := app.deliverState.ctx | |||
| blockHeight := ctx.BlockHeight() | |||
| if err := abciListener.ListenBeginBlock(app.deliverState.ctx, req, res); err != nil { | |||
| if err := abciListener.ListenBeginBlock(ctx, req, res); err != nil { | |||
There was a problem hiding this comment.
julienrbrt
commented
Mar 14, 2023
| @@ -426,15 +426,13 @@ func (app *BaseApp) DeliverTx(req abci.RequestDeliverTx) abci.ResponseDeliverTx | |||
| return sdkerrors.ResponseDeliverTxWithEvents(err, gInfo.GasWanted, gInfo.GasUsed, sdk.MarkEventsToIndex(anteEvents, app.indexEvents), app.trace) | |||
| } | |||
|
|
|||
| res = abci.ResponseDeliverTx{ | |||
| return abci.ResponseDeliverTx{ | |||
There was a problem hiding this comment.
julienrbrt
changed the title
julienrbrt
force-pushed
the
julien/chore-streaming
branch
from
7b38385 to
317a521
Compare
julienrbrt
force-pushed
the
julien/chore-streaming
branch
from
1525e8e to
f720c88
Compare
github-prbot
requested review from
JeancarloBarrios and
samricotta
and removed request for
a team
This was referenced Mar 14, 2023
julienrbrt
requested review from
alexanderbez and
kocubinski
and removed request for
JeancarloBarrios and
samricotta
alexanderbez
approved these changes
Mar 14, 2023
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #14207 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change