Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump to tagged version of CometBFT in v0.47 #15119

Merged
merged 6 commits into from
Feb 23, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 21, 2023

Description

ref: #14870

After this PR to v0.47 we are ready for v0.47-rc3

TODO

  • We need a follow-up on main for removing the replace from ./tests.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review February 21, 2023 21:22
@julienrbrt julienrbrt requested a review from a team as a code owner February 21, 2023 21:22
@github-actions github-actions bot added C:orm C:Rosetta Issues and PR related to Rosetta Type: Build labels Feb 21, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) February 21, 2023 23:28
@julienrbrt julienrbrt disabled auto-merge February 22, 2023 00:13
@julienrbrt
Copy link
Member Author

Checking the e2e..

@julienrbrt julienrbrt mentioned this pull request Feb 23, 2023
19 tasks
@julienrbrt julienrbrt added the S:blocked Status: Blocked label Feb 23, 2023
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Feb 23, 2023
@julienrbrt
Copy link
Member Author

merging already to get a buf commit for v0.47.
Then a PR targeting main will remove the replace from e2e and bump CometBFT with their fix.

@julienrbrt julienrbrt merged commit c830dad into release/v0.47.x Feb 23, 2023
@julienrbrt julienrbrt deleted the julien/047-cometbft branch February 23, 2023 20:58
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Rosetta Issues and PR related to Rosetta Type: Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants