-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: protoreflect based amino json encoder #14877
Merged
Merged
Changes from 128 commits
Commits
Show all changes
146 commits
Select commit
Hold shift + click to select a range
d953587
notes
kocubinski 5485fca
test proto gen
kocubinski 95fc572
Fix gen
kocubinski ca06ede
Add failing test case
kocubinski ca1e8c3
assert legacy behavior parity in test
kocubinski 35bb289
fix test to fail in the proper way
kocubinski ebec2a7
structurally sound, just handing marshal cases
kocubinski 6c6d4fe
Turning out pretty well
kocubinski a222053
initial test is now passing
kocubinski 9412ed0
some rapid tests failing
kocubinski fa13aff
rename
kocubinski 93b2a8d
rm rapid fail
kocubinski 0ab2d36
add test
kocubinski 6b79609
clean up test case
kocubinski 71382c7
test cleanup
kocubinski ee6f705
clean up commented code
kocubinski b1ac5e4
do not treat maps in generative tests
kocubinski b9ca7c4
rename files
kocubinski 76ae6a3
error on map marshal
kocubinski 6cf89b2
remove unused code
kocubinski 5170ce6
clean up
kocubinski a63eaca
clean up
kocubinski d59fd1c
create failing test case
kocubinski f341c67
handle amino.name option
kocubinski 0eedf02
begin annotation audit
kocubinski 164e26a
support more annotations
kocubinski a651645
Support more annotations, add one to distribution.proto
kocubinski f984ea8
handle amino.message_encoding
kocubinski a8d2dc2
refactor, clean up
kocubinski 2f18d53
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski c39f381
thank you linter
kocubinski ef4e87d
remove println
kocubinski 6947b3d
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski befbb6c
move package to x/tx/
kocubinski 1b0f2b1
refactor: fixing tests
kocubinski ef5f006
use pulsar for codegen
kocubinski 75008d8
clean up
kocubinski ca28ffc
Add one test case
kocubinski a1d7561
refactor: err handling and clean up
kocubinski cf060ed
fix any creation
kocubinski a2b4be3
check point, type index infra
kocubinski c19d317
deep copy working for some messages
kocubinski b699ec6
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 2ba8367
cd tx/tx && go mod tidy
kocubinski 98a12f1
Add amino annotation
kocubinski afea254
ModuleAccount parity achieved through annotations
kocubinski 5717b4a
progress
kocubinski 9671f17
auth finished
kocubinski 149816e
amino wip
kocubinski 2104382
gut cloning, in favor of proto round tripping
kocubinski 1520f3d
found parity with any types
kocubinski 100781f
a good tack
kocubinski e22421f
critical generator fixes for playing nicely with gogoproto dsz
kocubinski 0321a7f
bank passing
kocubinski 79b9626
wip
kocubinski 5b69d9b
fix json_marshal_test.go
kocubinski d2f7ae4
null_slice_as_empty encoding
kocubinski c0ef319
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski ee137a5
add requires back
kocubinski 9911efa
remove empty list tests
kocubinski bee2310
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 501cb90
incorporate changes from #14994 so that x/tx compiles with x/auth
kocubinski 94bcc46
bank annotations of null_slice_as_empty
kocubinski 612dfb3
refactor, cleanup
kocubinski ca9bfd0
all parity and gen tests passing for so far included modules
kocubinski f841fb9
rm confusion
kocubinski 41c9791
add distribution
kocubinski bb2b03d
evidence
kocubinski a62d3f7
add feegrant
kocubinski 25e64ea
gov v1beta1
kocubinski e7fa027
gov v1
kocubinski 338687f
group module
kocubinski 80684a5
nft module
kocubinski e5076f5
params module
kocubinski 583181c
slashing module
kocubinski ff86798
WIP staking
kocubinski 9f0f51a
test clean up
kocubinski 8b04d2f
add breaking oneof tests
kocubinski 5946320
oneof tests passing, trying a refactor though
kocubinski 30930d9
upgrade module
kocubinski 5f0db4d
vesting module
kocubinski 732bcaf
remove embedded handling
kocubinski 54ee03d
rm defunct tests
kocubinski 1a23420
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski a6c49dd
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 144df31
merge, go.mod
kocubinski 8960d43
rm defunct option
kocubinski 721d30a
clean up module account proto
kocubinski dabfb48
add comments
kocubinski 67bb9af
demonstration of repeated field complexity
kocubinski 5670e89
add comment
kocubinski 6da5d25
add another message case
kocubinski 283bbdd
clarify cases
kocubinski b8fd077
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski ebf3283
coins by convention.
kocubinski 4fc10c9
Revert "coins by convention."
kocubinski b33fa59
change field encoder name
kocubinski 019e230
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 53e36f9
use convention for oneof field names
kocubinski 51f0e2d
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 81c1d5a
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski b12b678
a little cleanup on the test suite
kocubinski 5a48d89
comments and clean up
kocubinski a1898b3
revert line
kocubinski 0702382
clean up
kocubinski 83a6f05
go mod tidy
kocubinski 058479d
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 82382e3
use api v0.3.1
kocubinski 8bcc725
update test seeds
kocubinski 298b6ea
Merge branch 'main' into kocubinski/amino-json
JeancarloBarrios 2a77cc6
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 8f6cec9
update rapidproto test seeds
kocubinski f971768
use rapidproto package from cosmos-proto
kocubinski 60180b3
use replace directive instead of go.work
kocubinski 036d428
replace directive for client/v2 in tests
kocubinski f6473d3
refactor to support custom field mapping
kocubinski 49543ec
update cosmos-proto version
kocubinski c55648a
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 35bc669
wip docs, refactor, clean up
kocubinski 9e0ae46
break out options.go
kocubinski cbb277e
Update x/tx/aminojson/any.go
kocubinski c7a7e4c
return err if not nil
kocubinski c6b1de9
add docs
kocubinski 8533753
refactor marshalAny a bit
kocubinski 21e7d77
fix error message
kocubinski fad3130
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 9ffbf76
refactor byte array case
kocubinski 11d45af
Merge branch 'main' into kocubinski/amino-json
kocubinski be04a65
support math.Int as bytes
kocubinski 5d66060
reverse mistaken change
kocubinski b0486f5
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 588ff72
Update x/tx/aminojson/json_marshal.go
kocubinski 97bcc1a
implement special handling for LegacyAminoPubKey
kocubinski 405a076
Merge branch 'kocubinski/amino-json' of github.com:cosmos/cosmos-sdk …
kocubinski 73207ae
revert to struct receiver methods
kocubinski daa5cf5
Merge branch 'main' into kocubinski/amino-json
kocubinski 9c98673
Merge branch 'main' into kocubinski/amino-json
kocubinski 5769996
rm replace directive
kocubinski a5d45bd
rename AminoJSON struct -> Encoder
kocubinski 60feafc
Rename Encoder.MarshalAmino -> Encoder.Marshal
kocubinski 9cb66d0
fix name collision
kocubinski e100fdd
change signature of message encoders to include encoder struct
kocubinski 90fa320
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/a…
kocubinski 14ac34a
go mod tidy
kocubinski 8481613
Merge branch 'main' into kocubinski/amino-json
kocubinski c1a6aa2
Merge branch 'main' into kocubinski/amino-json
kocubinski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| testdata | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right