Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove .Type() and .Route() from msgs #14751

Merged
merged 13 commits into from
Jan 24, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 24, 2023

Description

Remove .Type() and .Route() from all msgs and reflect that in the simulator.
ref: #14728, #14753


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

types/tx_msg.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the C:CLI label Jan 24, 2023
@julienrbrt julienrbrt changed the title refactor: msgs refactor: remove .Type() and .Route() from msgs Jan 24, 2023
@julienrbrt julienrbrt marked this pull request as ready for review January 24, 2023 15:25
@julienrbrt julienrbrt requested a review from a team as a code owner January 24, 2023 15:25
@julienrbrt
Copy link
Member Author

julienrbrt commented Jan 24, 2023

To backport or not to backport to v0.47.1, this is the question. There is no breaking change, neither feature change, only a cleanup. Except from one field removal in simulation. IMHO this is a good improvement.

As we don't backport this for v0.47.0, I will just add the .Type() and .Route() methods for MsgUpdateParams in the backported PR of this: #14728. Then if we backport this in v0.47.1, we can just remove these methods too.

@@ -160,14 +160,6 @@ type TestEvidence struct{}

var _ exported.Evidence = &TestEvidence{}

func (*TestEvidence) Route() string {
Copy link
Member Author

@julienrbrt julienrbrt Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING!

x/authz/msgs.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) January 24, 2023 16:57
@julienrbrt julienrbrt merged commit 8dbdfea into main Jan 24, 2023
@julienrbrt julienrbrt deleted the julien/refactor-msgs branch January 24, 2023 17:03
@julienrbrt julienrbrt mentioned this pull request Jan 25, 2023
19 tasks
@tac0turtle
Copy link
Member

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

backport release/v0.47.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 20, 2023
(cherry picked from commit 8dbdfea)

# Conflicts:
#	CHANGELOG.md
#	x/distribution/types/msg.go
#	x/evidence/types/msgs.go
#	x/gov/client/utils/query_test.go
#	x/gov/simulation/operations.go
#	x/gov/simulation/operations_test.go
#	x/gov/types/v1/msgs.go
#	x/staking/simulation/operations_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants