-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: module circuit breaker #14521
feat: module circuit breaker #14521
Conversation
Co-authored-by: Aaron Craelius <aaron@regen.network>
We need an extra message that can be only called by an authority (so for gov) for allowing to define admins ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd document somewhere on why both the Msg Router and AnteHandler chain both need access to the circuit breaker. Otherwise, LGTM.
@@ -87,7 +87,6 @@ https://github.com/cosmos/cosmos-sdk/blob/main/proto/cosmos/circuit/v1/tx.proto# | |||
This message is expected to fail if: | |||
|
|||
* the granter is not an account with permission level `LEVEL_SUPER_ADMIN` or the module authority |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to precise the granter can be governance as well and that gov is considered as LEVEL_SUPER_ADMIN
as well.
You were right Marko, never mind this comment. I do think a precision in the docs would, however, be useful: #14521 (comment) |
Co-authored-by: Aaron Craelius <aaron@regen.network> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Sam Ricotta <samanthalricotta@gmail.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Description
add circuit breaker module
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change