Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use assertNotPanics util instead of testify/require in genutil tests #14518

Closed
wants to merge 6 commits into from
Closed

refactor: Use assertNotPanics util instead of testify/require in genutil tests #14518

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4a6047
wip: replace testify with gotest.tools in staking integration tests
likhita-809 Jan 5, 2023
324a260
use assertNotPanics util instead of testify/require in gentx tests
likhita-809 Jan 6, 2023
ba26ab8
use assert panic utils instead of testify require
likhita-809 Jan 6, 2023
dbd4a44
Merge branch 'likhita/replace-testify-staking-integration-tests' of h…
likhita-809 Jan 6, 2023
8ccab92
remove unused imports
likhita-809 Jan 6, 2023
99ce51f
move assert utils to testutil pkg
likhita-809 Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/integration/genutil/gentx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"testing"
"time"

"github.com/stretchr/testify/require"
tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
"gotest.tools/v3/assert"

Expand Down Expand Up @@ -299,7 +298,7 @@ func TestDeliverGenTxs(t *testing.T) {
tc.malleate()

if tc.expPass {
require.NotPanics(t, func() {
assertNotPanics(t, func() {
genutil.DeliverGenTxs(
f.ctx, genTxs, f.stakingKeeper, f.baseApp.DeliverTx,
f.encodingConfig.TxConfig,
Expand All @@ -316,3 +315,12 @@ func TestDeliverGenTxs(t *testing.T) {
})
}
}

func assertNotPanics(t *testing.T, f func()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, best to have the utils function in the SDK, so we can use them everywhere.

defer func() {
if r := recover(); r != nil {
t.Errorf("should not panic: %v", r)
}
}()
f()
}