Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace testify with gotest.tools in genutil integration tests #14479

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented Jan 4, 2023

Description

closes: #14492
ref: #12332 #14145


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review January 4, 2023 15:35
@likhita-809 likhita-809 requested a review from a team as a code owner January 4, 2023 15:35
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, two nits.

tests/integration/genutil/gentx_test.go Outdated Show resolved Hide resolved
tests/integration/genutil/gentx_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple of nits.

Comment on lines +10 to +12
"github.com/stretchr/testify/require"
tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
"gotest.tools/v3/assert"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use any of assert or require? or both are required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be using only assert but there are less utilities available in gotest.tools, so I used require whenever there is a panic check since there isn't one in assert to do that.
This will be fine as of now because our main goal is to run tests standalone without any suite.

Copy link
Contributor

@alexanderbez alexanderbez Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we write our own util using assert?

func AssertNotPanics(fn func())  {
  defer {
    // recover and use assert to ensure no error
  }()

  fn()
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certainly, I could do that in next PR's and will do a follow-up for genutil tests

tests/integration/genutil/gentx_test.go Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) January 5, 2023 08:55
@julienrbrt julienrbrt merged commit 0a7bcd2 into main Jan 5, 2023
@julienrbrt julienrbrt deleted the likhita/replace-testify-genutil-integration-tests branch January 5, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Replace testify with gotest.tools in integration/genutil tests
5 participants