Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(distribution): correct default for deprecated distribution params #14462

Merged
merged 6 commits into from
Jan 2, 2023
Merged

fix(distribution): correct default for deprecated distribution params #14462

merged 6 commits into from
Jan 2, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 2, 2023 •
edited
Loading

Description

Closes: #14358
Came up during #14358 (related #12876)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jan 2, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner January 2, 2023 13:22
@github-actions github-actions bot added C:Simulations C:x/distribution distribution module related labels Jan 2, 2023
@julienrbrt julienrbrt closed this Jan 2, 2023
@julienrbrt julienrbrt reopened this Jan 2, 2023
@github-actions github-actions bot added the C:x/genutil genutil module issues label Jan 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

tac0turtle
tac0turtle reviewed Jan 2, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

samricotta
samricotta approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@samricotta samricotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt enabled auto-merge (squash) January 2, 2023 16:35
@julienrbrt julienrbrt merged commit bca18ba into main Jan 2, 2023
@julienrbrt julienrbrt deleted the julien/distr-params branch January 2, 2023 17:54
mergify bot pushed a commit that referenced this pull request Jan 2, 2023
@julienrbrt @mergify
fix(distribution): correct default for deprecated distribution params (…
aac9341 
…#14462)

(cherry picked from commit bca18ba)

# Conflicts:
#	x/bank/simulation/genesis_test.go
@mergify mergify bot mentioned this pull request Jan 2, 2023
Merged
julienrbrt added a commit that referenced this pull request Jan 2, 2023
@mergify @julienrbrt
fix(distribution): correct default for deprecated distribution params…
71c1ee2 
… (backport #14462) (#14463)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@alexanderbez
Copy link
Contributor

Thank you @julienrbrt 🙏

@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@samricotta samricotta samricotta approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees

@tac0turtle tac0turtle

@samricotta samricotta

Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:Simulations C:x/bank C:x/distribution distribution module related C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test params / Make gov proposals for all params
4 participants
@julienrbrt @alexanderbez @tac0turtle @samricotta