Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: backport pr 13881 #14349

Merged
merged 8 commits into from
Jan 5, 2023
Merged

chore: backport pr 13881 #14349

merged 8 commits into from
Jan 5, 2023

Conversation

tac0turtle
Copy link
Member

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

yihuang and others added 5 commits December 16, 2022 05:05
@yihuang @mergify
perf: optimize iteration on nested cache context (#13881)
7dbe4fc 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Closes #10310

(cherry picked from commit cbee1b3)

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	simapp/go.mod
#	simapp/go.sum
#	store/cachekv/store.go
#	store/cachekv/store_test.go
#	tests/go.mod
#	tests/go.sum
@julienrbrt
fix part of conflicts
9ed5074
@yihuang
Update store/cachekv/store.go
2bcd310
@tac0turtle
conflicts
f02a85a
@tac0turtle
use older version
5896034
@tac0turtle tac0turtle changed the base branch from main to release/v0.46.x December 17, 2022 13:58
@tac0turtle tac0turtle changed the title Mergify/bp/release/v0.46.x/pr 13881 backport pr 13881 Dec 17, 2022
@tac0turtle tac0turtle marked this pull request as ready for review December 17, 2022 13:59
@tac0turtle tac0turtle requested a review from a team as a code owner December 17, 2022 13:59
yihuang
yihuang reviewed Dec 17, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@tac0turtle tac0turtle changed the title backport pr 13881 chore: backport pr 13881 Dec 17, 2022
@tac0turtle
Copy link
Member Author

@yihuang any chance you can take a look at the failing test?

likhita-809
likhita-809 reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihuang can you look into the failing test TestNilEndIterator here too ?

kocubinski and others added 2 commits January 5, 2023 11:08
@kocubinski @tac0turtle
fix(store): handle nil end in cachekv/iterator (#12945)
9a2e881 
Closes: #12661

Adds support for nil end semantics to iterators in cachekv store, addressing [this workaround](https://github.com/osmosis-labs/osmosis/blob/4176b287d48338870bfda3029bfa20a6e45ac126/osmoutils/store_helper.go#L37-L41).

Note that this has the effect of sorting the dirty cache into the BTree cache store in the bounds `[startIndex, end-of-cache-space]`

---

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@tac0turtle
Merge branch 'release/v0.46.x' into mergify/bp/release/v0.46.x/pr-13881
344b8e2
julienrbrt
julienrbrt approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tac0turtle tac0turtle merged commit 93fd49d into release/v0.46.x Jan 5, 2023
@tac0turtle tac0turtle deleted the mergify/bp/release/v0.46.x/pr-13881 branch January 5, 2023 13:42
@SpicyLemon SpicyLemon mentioned this pull request Jan 25, 2023
Closed
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Jan 25, 2023
@SpicyLemon
Revert "chore: backport pr 13881 (cosmos#14349)"
bd32192 
This reverts commit 93fd49d.
@SpicyLemon SpicyLemon mentioned this pull request Jan 25, 2023
Merged
19 tasks
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Jan 25, 2023
@SpicyLemon
Prov/dwedul/revert store (#444)
f13732b 
* Revert "chore: backport pr 13881 (cosmos#14349)"

This reverts commit 93fd49d.

* Undo the changelog revert and add an entry in our section about the revert.
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Jan 25, 2023
@SpicyLemon
Revert cosmos#14349 - cache iterator optimizations (#444)
cd9d192 
* Revert "chore: backport pr 13881 (cosmos#14349)"

This reverts commit 93fd49d.

* Undo the changelog revert and add an entry in our section about the revert.
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Feb 9, 2023
@SpicyLemon
Revert "Revert cosmos#14349 - cache iterator optimizations (#444)"
315dd07 
This reverts commit cd9d192.
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Feb 16, 2023
@SpicyLemon @mergify
@likhita-809 @yihuang @julienrbrt @tac0turtle @mmsqe @robert-zaremba @elias-orijtech @facundomedica
Backport: #505 (v0.46.9) #517 (v0.46.10) and #510 (sanction Tx CLI) (#…
cf6f99f 
…518)

* fix: Fix Evidence CLI query flag parsing (backport cosmos#13458) (cosmos#14799)

Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Co-authored-by: HuangYi <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* fix: nested iterator on cache store (cosmos#14798)

* chore: update IAVL  (backport cosmos#14830) (cosmos#14835)

Co-authored-by: Marko <marbar3778@yahoo.com>

* Mark v0.46.8-pio-2 in the changelog and release notes.

* feat: add config `iavl-lazy-loading` to enable lazy loading of iavl store (backport cosmos#14189) (cosmos#14862)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* chore: bump IAVL to v0.19.5 (backport cosmos#14889) (cosmos#14892)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* build(deps): bump tendermint to v0.34.25 (cosmos#14903)

* build(deps): bump tendermint to v0.34.26 (cosmos#14911)

* fix: return named error for write validators (backport cosmos#14919) (cosmos#14921)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Bump Tendermint to v0.34.25 (from v0.34.24). (#498)

* Fix a few listener proto comments. (#499)

* build(deps): bump btcd in v0.46 (cosmos#14846)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Elias Naur <103319121+elias-orijtech@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>

* ci: update release slack channel and algolia api key (backport cosmos#14942) (cosmos#14945)

Co-authored-by: Julien Robert <julien@rbrt.fr>

* feat: support profiling block replay during abci handshake (backport cosmos#14953) (cosmos#14964)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Revert "Revert cosmos#14349 - cache iterator optimizations (#444)"

This reverts commit cd9d192.

* Mark v0.46.8-pio-3 in the changelog and release notes.

* fix: avoid broadcasting tx through query (backport cosmos#15044) (cosmos#15047)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* Add CLI commands for sanction Tx gov props (#510)

* Fix the changelog.

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Co-authored-by: HuangYi <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Elias Naur <103319121+elias-orijtech@users.noreply.github.com>
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
jiujiteiro pushed a commit to realiotech/cosmos-sdk that referenced this pull request Mar 7, 2023
@tac0turtle @yihuang
@julienrbrt @kocubinski @jiujiteiro
chore: backport pr 13881 (cosmos#14349)
f134bc1 
Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang left review comments

@julienrbrt julienrbrt julienrbrt approved these changes

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees

@facundomedica facundomedica

@likhita-809 likhita-809

Labels
C:Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tac0turtle @yihuang @julienrbrt @likhita-809 @facundomedica @kocubinski