Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GenSignedMockTx #13557

Merged
merged 8 commits into from
Oct 16, 2022
Merged

feat: add GenSignedMockTx #13557

merged 8 commits into from
Oct 16, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Oct 15, 2022 •
edited
Loading

Description

We had to revert #12437 due to an API breaking change in v0.45.9.
This brings back the fix in a non API breaking change way (using the same name and signature we have in v0.46).

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

julienrbrt
julienrbrt commented Oct 15, 2022
View reviewed changes
CHANGELOG.md
@@ -112,6 +115,9 @@ replace (
### Bug Fixes

* (x/mint) [#12384](https://github.com/cosmos/cosmos-sdk/pull/12384) Ensure `GoalBonded` must be positive when performing `x/mint` parameter validation.
* (simapp) [#12437](https://github.com/cosmos/cosmos-sdk/pull/12437) fix the non-determinstic behavior in simulations caused by `GenTx` and check
Copy link
Member Author

@julienrbrt julienrbrt Oct 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed that in our security fix, however this should not be removed, as it is obviously still included in that version.

julienrbrt
julienrbrt commented Oct 15, 2022
View reviewed changes
simapp/helpers/test_helpers.go
}

// GenSignedMockTx generates a signed mock transaction.
func GenSignedMockTx(r *rand.Rand, gen client.TxConfig, msgs []sdk.Msg, feeAmt sdk.Coins, gas uint64, chainID string, accNums, accSeqs []uint64, priv ...cryptotypes.PrivKey) (sdk.Tx, error) {
Copy link
Member Author

@julienrbrt julienrbrt Oct 15, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as there https://github.com/cosmos/cosmos-sdk/blob/v0.46.2/simapp/helpers/test_helpers.go#L21

julienrbrt
julienrbrt commented Oct 16, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
julienrbrt
julienrbrt commented Oct 16, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tac0turtle
tac0turtle approved these changes Oct 16, 2022
View reviewed changes
simapp/helpers/test_helpers.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 0622dd4 into release/v0.45.x Oct 16, 2022
@alexanderbez alexanderbez deleted the julien/changelog-045 branch October 16, 2022 22:56
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Oct 24, 2022
@SpicyLemon @aaronc
@ValarDragon @julienrbrt @alexanderbez @nddeluca @mergify @gsk967
Apply v0.45.10 changes and prep changelog for v0.45.10-pio-1 (#318)
78cb115 
* fix: move ics23 to correct folder (cosmos#13549)

* fix: fix liveness tests cosmos#13551

* feat: add `GenSignedMockTx` (cosmos#13557)

* fix: fix `make proto-gen` (cosmos#13564)

* fix: fix `make proto-gen`

* add changelog

* feat: [REDO] gRPC query for operator and chain configuration (backport cosmos#13485) (cosmos#13589)

* chore: bump tendermint to `0.34.22` (cosmos#13585)

* fix: (v0.45.x) regression in return value of WithdrawDelegationRewards when rewards are zero (cosmos#13588)

* fix(server): v0.45.x Populate the PruningKeepEvery config entry in GetConfig. (cosmos#13610)

* Populate the PruningKeepEvery config entry in GetConfig.

* Update changlog.

* feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13617)

* feat(cli): add module-account cli cmd and grpc get api (cosmos#13612)

(cherry picked from commit ddf5cf0)

# Conflicts:
#	CHANGELOG.md
#	api/cosmos/auth/v1beta1/query.pulsar.go
#	api/cosmos/auth/v1beta1/query_grpc.pb.go
#	proto/cosmos/auth/v1beta1/query.proto
#	tests/e2e/auth/suite.go
#	x/auth/client/cli/query.go
#	x/auth/keeper/grpc_query.go
#	x/auth/keeper/grpc_query_test.go
#	x/auth/types/query.pb.go
#	x/auth/types/query.pb.gw.go

* update changelog

* fix conflicts

Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare 0.45.10 changelog (cosmos#13624)

* chore: prepare 0.45.10 changelog

* default release notes

* period

* Add missing changelog section for v0.45.9-pio-1.

* Remove the old release notes.

* Remove accidentally duplicated section for v0.45.4.

* Add new v0.45.10-pio-1 section to the changelog and update the release notes to reflect our stuff.

* Include a 'nothing' under unreleased.

* Add links to changlog entries.

Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
jaybxyz pushed a commit to cosmosquad-labs/cosmos-sdk that referenced this pull request Nov 1, 2022
@julienrbrt @jaybxyz
feat: add GenSignedMockTx (cosmos#13557)
abfd35d 
(cherry picked from commit 0622dd4)
nnkken pushed a commit to likecoin/cosmos-sdk that referenced this pull request Nov 16, 2022
@julienrbrt @nnkken
feat: add GenSignedMockTx (cosmos#13557)
07df5fd
drklee3 pushed a commit to Kava-Labs/cosmos-sdk that referenced this pull request Feb 16, 2023
@julienrbrt @drklee3
feat: add GenSignedMockTx (cosmos#13557)
7b6455d
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

Assignees
No one assigned
Labels
C:Simulations C:x/authz C:x/bank C:x/distribution distribution module related C:x/genutil genutil module issues C:x/gov C:x/slashing C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienrbrt @alexanderbez @tac0turtle @adu-web3