Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fix some Amino registrations #13502

Merged
merged 5 commits into from
Oct 11, 2022
Merged

fix!: Fix some Amino registrations #13502

merged 5 commits into from
Oct 11, 2022

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Oct 11, 2022

Description

While auditing the Msgs, I noticed some Amino registrations were missing or incorrect. This PR fixes them. Since this is a state machine breaking change, it would be good to merge this before v0.47.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 added the T: State Machine Breaking State machine breaking changes (impacts consensus). label Oct 11, 2022
@github-actions github-actions bot removed the C:x/gov label Oct 11, 2022
@amaury1093 amaury1093 marked this pull request as ready for review October 11, 2022 09:53
@amaury1093 amaury1093 requested a review from a team as a code owner October 11, 2022 09:53
@amaury1093 amaury1093 enabled auto-merge (squash) October 11, 2022 10:02
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #13502 (dfa9688) into main (1917e92) will decrease coverage by 0.85%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13502      +/-   ##
==========================================
- Coverage   54.75%   53.89%   -0.86%     
==========================================
  Files         685      643      -42     
  Lines       58767    55468    -3299     
==========================================
- Hits        32178    29896    -2282     
+ Misses      23895    23171     -724     
+ Partials     2694     2401     -293     
Impacted Files Coverage Δ
x/auth/vesting/types/codec.go 100.00% <100.00%> (ø)
x/bank/types/codec.go 60.00% <100.00%> (+1.37%) ⬆️
x/slashing/types/codec.go 66.66% <100.00%> (ø)
x/distribution/simulation/operations.go 80.64% <0.00%> (-9.68%) ⬇️
tx/textual/valuerenderer/dec.go
orm/encoding/ormfield/codec.go
tx/textual/valuerenderer/int.go
orm/encoding/ormkv/key_codec.go
orm/model/ormtable/paginate.go
orm/model/ormtable/util.go
... and 38 more

@amaury1093 amaury1093 merged commit 56709d4 into main Oct 11, 2022
@amaury1093 amaury1093 deleted the am/fix-amino-codec branch October 11, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/auth C:x/bank C:x/slashing T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants