feat: add proto annotation for Msg services

[aaronc]

Description

Similarly to #13174, this adds the cosmos.msg.v1.service annotation as specified in #12972 and #12239.

This will allow tooling to distinguish between Msg and Query services via reflection which could allow:

• unified registration of services with a single grpc.ServiceRegistrar
• use of a single grpc.ClientConnInterface for ADR-033

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

This needs a changelog and documentation. I'm not sure how this really plays into framework or if this is the right path.

[aaronc]

This needs a changelog and documentation. I'm not sure how this really plays into framework or if this is the right path.

I'll add a changelog entry.

What alternative would you suggest? Not sure what other documentation is needed. This simply annotates services as Msg services so any sort of tooling can distinguish between Msg and Query services.

[codecov]

Codecov Report

Merging #13178 (8305330) into main (641ab20) will increase coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13178      +/-   ##
==========================================
+ Coverage   54.94%   55.01%   +0.07%     
==========================================
  Files         648      653       +5     
  Lines       55366    55521     +155     
==========================================
+ Hits        30419    30544     +125     
- Misses      22501    22522      +21     
- Partials     2446     2455       +9     

Impacted Files	Coverage Δ
tx/textual/valuerenderer/dec.go	72.41% <0.00%> (ø)
tx/textual/valuerenderer/valuerenderer.go	78.72% <0.00%> (ø)
tx/textual/valuerenderer/timestamp.go	100.00% <0.00%> (ø)
tx/textual/valuerenderer/bytes.go	53.84% <0.00%> (ø)
tx/textual/valuerenderer/int.go	77.77% <0.00%> (ø)
x/group/keeper/keeper.go	56.64% <0.00%> (+0.39%)	⬆️
crypto/keys/internal/ecdsa/privkey.go	83.01% <0.00%> (+1.88%)	⬆️

[amaury1093]

LGTM

[amaury1093]

Not sure what other documentation is needed.

Module developer docs, and maybe upgrading guide. Or else the app developers' Msg services won't get hooked with e.g. the auto-generated cli when they upgrade their sdk version.

[kocubinski]

Additive metadata so LGTM.

[aaronc]

Okay to move forward with this @marbar3778 ?

dismiss

[aaronc]

@marbar3778 it seems that github auto-merge won't work without an explicit approval from you. It says:

Because you reviewed on behalf of cosmos/sdk-core-dev previously then seems like you automatically become the reviewer for that team even though @AmauryM and @kocubinski approved:

Strange...