Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: printf for Record protobuf gen struct #12978

Closed
wants to merge 9 commits into from
Closed

Conversation

raynaudoe
Copy link
Contributor

Description

Closes: #11368


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • [] included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #12978 (a712319) into main (6a4d2a1) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12978      +/-   ##
==========================================
- Coverage   53.28%   53.21%   -0.08%     
==========================================
  Files         651      646       -5     
  Lines       55393    55238     -155     
==========================================
- Hits        29515    29393     -122     
+ Misses      23524    23499      -25     
+ Partials     2354     2346       -8     
Impacted Files Coverage Δ
tx/textual/valuerenderer/timestamp.go
tx/textual/valuerenderer/bytes.go
tx/textual/valuerenderer/int.go
tx/textual/valuerenderer/dec.go
tx/textual/valuerenderer/valuerenderer.go
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

@raynaudoe raynaudoe closed this Sep 3, 2022
@raynaudoe raynaudoe deleted the eze/fix_record_printf branch September 6, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keyring API doesn't work as expected
1 participant