Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deterministic map iteration (backport #12781) #12943

Merged
merged 4 commits into from
Aug 18, 2022

Commits on Aug 17, 2022

  1. feat: deterministic map iteration (#12781)

    ## Description
    
    We should ensure that events emitted are in a deterministic order on any node.
    
    Sorry, the previous [PR-12693](#12693) was closed due to wrong operation.
    
    Close: #12693
    
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [x] added `!` to the type prefix if API or client breaking change
    - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
    - [x] provided a link to the relevant issue or specification
    - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
    - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
    - [x] added a changelog entry to `CHANGELOG.md`
    - [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [x] updated the relevant documentation or specification
    - [x] reviewed "Files changed" and left comments if necessary
    - [x] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit 6ed11b8)
    
    # Conflicts:
    #	CHANGELOG.md
    bruce-wayne2 authored and mergify[bot] committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    2a4aeb6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddbf93b View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. go mod tidy

    julienrbrt committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    472cd8b View commit details
    Browse the repository at this point in the history
  2. fix test

    julienrbrt committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    4a35805 View commit details
    Browse the repository at this point in the history