Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update wording in ADR-044 #12683

Merged
merged 4 commits into from
Jul 23, 2022
Merged

chore: Update wording in ADR-044 #12683

merged 4 commits into from
Jul 23, 2022

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented Jul 21, 2022

Description

ref: #12670 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 requested a review from a team as a code owner July 21, 2022 18:25
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 23, 2022
@mergify mergify bot merged commit 6145eea into main Jul 23, 2022
@mergify mergify bot deleted the am/update-adr044 branch July 23, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. Type: ADR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants